style: improve selected row contrast

Author: nsumbadze

pkg/config/app_config.go

@@ -240,6 +240,9 @@ func GetDefaultConfig() []byte {
       - blue
     selectedLineBgColor:
       - blue
+    selectedLineFgColor:
+      - white
+      - bold
 update:
   method: prompt # can be: prompt | background | never
   days: 14 # how often a update is checked for

pkg/gui/layout.go

@@ -7,6 +7,13 @@ import (
 	"github.com/jesseduffield/lazynpm/pkg/utils"
 )
 
+// applyListHighlight keeps the focused row readable across all list panels.
+// gocui does not automatically use the configured theme value for selected rows.
+func (gui *Gui) applyListHighlight(view *gocui.View) {
+	view.SelBgColor = theme.SelectedLineBgColor
+	view.SelFgColor = theme.SelectedLineFgColor
+}
+
 // getFocusLayout returns a manager function for when view gain and lose focus
 func (gui *Gui) getFocusLayout() func(g *gocui.Gui) error {
 	var previousView *gocui.View
@@ -249,6 +256,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		packagesView.Title = gui.panelTitle("packages", 2, gui.Tr.SLocalize("PackagesTitle"))
 		packagesView.ContainsList = true
 	}
+	gui.applyListHighlight(packagesView)
 
 	depsView, err := g.SetViewBeneath("deps", "packages", vHeights["deps"])
 	if err != nil {
@@ -259,6 +267,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		depsView.FgColor = textColor
 		depsView.ContainsList = true
 	}
+	gui.applyListHighlight(depsView)
 
 	scriptsView, err := g.SetViewBeneath("scripts", "deps", vHeights["scripts"])
 	if err != nil {
@@ -269,6 +278,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		scriptsView.FgColor = textColor
 		scriptsView.ContainsList = true
 	}
+	gui.applyListHighlight(scriptsView)
 
 	tarballsView, err := g.SetViewBeneath("tarballs", "scripts", vHeights["tarballs"])
 	if err != nil {
@@ -279,6 +289,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
 		tarballsView.FgColor = textColor
 		tarballsView.ContainsList = true
 	}
+	gui.applyListHighlight(tarballsView)
 	tarballsView.Visible = gui.showTarballsView()
 
 	if v, err := g.SetView("options", appStatusOptionsBoundary-1, height-2, optionsVersionBoundary-1, height, 0); err != nil {

pkg/gui/menu_panel.go

@@ -78,6 +78,7 @@ func (gui *Gui) createMenu(title string, items []*menuItem, createMenuOptions cr
 	menuView.Title = title
 	menuView.FgColor = theme.GocuiDefaultTextColor
 	menuView.ContainsList = true
+	gui.applyListHighlight(menuView)
 	menuView.Clear()
 	fmt.Fprint(menuView, list)
 	gui.State.Panels.Menu.SelectedLine = 0

pkg/theme/theme.go

@@ -22,7 +22,9 @@ var (
 	InactiveBorderColor gocui.Attribute
 
 	// SelectedLineBgColor is the background color for the selected line
-	SelectedLineBgColor color.Attribute
+	SelectedLineBgColor gocui.Attribute
+	// SelectedLineFgColor is the foreground color for the selected line
+	SelectedLineFgColor gocui.Attribute
 
 	OptionsFgColor color.Attribute
 
@@ -35,7 +37,12 @@ var (
 func UpdateTheme(userConfig *viper.Viper) {
 	ActiveBorderColor = GetGocuiColor(userConfig.GetStringSlice("gui.theme.activeBorderColor"))
 	InactiveBorderColor = GetGocuiColor(userConfig.GetStringSlice("gui.theme.inactiveBorderColor"))
-	SelectedLineBgColor = GetBgColor(userConfig.GetStringSlice("gui.theme.selectedLineBgColor"))
+	SelectedLineBgColor = GetGocuiBgColor(userConfig.GetStringSlice("gui.theme.selectedLineBgColor"))
+	selectedLineFgColor := userConfig.GetStringSlice("gui.theme.selectedLineFgColor")
+	if len(selectedLineFgColor) == 0 {
+		selectedLineFgColor = []string{"white", "bold"}
+	}
+	SelectedLineFgColor = GetGocuiColor(selectedLineFgColor)
 	OptionsColor = GetGocuiColor(userConfig.GetStringSlice("gui.theme.optionsTextColor"))
 	OptionsFgColor = GetFgColor(userConfig.GetStringSlice("gui.theme.optionsTextColor"))
 
@@ -129,6 +136,29 @@ func GetGocuiColor(keys []string) gocui.Attribute {
 	return attribute
 }
 
+// GetGocuiBgColor converts configured background colors to gocui attributes.
+func GetGocuiBgColor(keys []string) gocui.Attribute {
+	colorMap := map[string]gocui.Attribute{
+		"default": gocui.ColorDefault,
+		"black":   gocui.ColorBlack,
+		"red":     gocui.ColorRed,
+		"green":   gocui.ColorGreen,
+		"yellow":  gocui.ColorYellow,
+		"blue":    gocui.ColorBlue,
+		"magenta": gocui.ColorMagenta,
+		"cyan":    gocui.ColorCyan,
+		"white":   gocui.ColorWhite,
+		"bold":    gocui.AttrBold,
+	}
+	var attribute gocui.Attribute
+	for _, key := range keys {
+		if value, present := colorMap[key]; present {
+			attribute |= value
+		}
+	}
+	return attribute
+}
+
 // GetColor bitwise OR's a list of attributes obtained via the given keys
 func GetBgColor(keys []string) color.Attribute {
 	var attribute color.Attribute