-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update documentation and merged fixes #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*merge from my old different pr. ## New parameter and improvement - Updated script parameters to include a new $p_IsoDisk parameter. - Renamed $ScratchDisk to $p_ScratchDisk throughout the script. - Added logic to handle $p_IsoDisk, prompting user if not provided. - Removed output of scratch disk setting. - Change the ordre to match iso then scratch - Rename parameter - Adding pattern for second one too - Adding synopsis with some informations on the script and calling exemples. ## New Functions for optimisation - Introduced Remove-RegistryValue and Set-RegistryValue functions to replace direct reg commands for registry modifications. ## Auto Dismount - Dismounting the iso image after process completion. ## SKU validation - Added validation to ensure the entered index is valid by checking against available indices in the Windows image file. - Introduced a loop to repeatedly prompt the user until a valid index is provided. ## Others - Updated `.gitignore` to exclude Visual Studio files. - Revised `README.md` for clarity and added new features.
Implement a check for the existence of `autounattend.xml`. If the file is not found, download it from a specified URL using `Invoke-RestMethod` and save it to the script's root directory. This ensures the configuration file is available for the script's execution.
Updated `tiny11maker.ps1` to replace `Remove-RegistryKey` with `Remove-RegistryValue` for specific registry values. Expanded the cleanup section to include detailed checks and messages for the existence and removal of temporary files and directories, improving script robustness and user feedback.
…k/tiny11builderDev into Merged-PR-tiny11maker.ps1
- Add new packages in `$packagePrefixes`. - Change disposiition of `$packagePrefixes` to better lisibility. - Modify the `where-object` query param from `-like "$_*"` to `-like "*$_*"`
Enhance cleanup process
|
Summary of PSScriptAnalyzer Errors and Warnings1. PSUseShouldProcessForStateChangingFunctionsType: Warning
2. PSAvoidUsingWriteHostType: Warning 3. PSAvoidUsingPositionalParametersType: Information 4. PSAvoidTrailingWhitespaceType: Information 5. PSAvoidUsingEmptyCatchBlockType: Warning |
- Fix `PSAvoidTrailingWhitespace` - Fix `PSAvoidUsingWriteHost` - Fix `PSAvoidUsingEmptyCatchBlock` - Fix `PSUseShouldProcessForStateChangingFunctions` > False positive, it does not touch the running system registry. For `PSAvoidUsingPositionalParameters` i can add named parameters but it's not mandatory if positional is repected.
Fixes for PSScriptAnalysis report
For |
Conflict resolution (ecd3c83)
|
Purpose :
Details :
Adding SKU validation (#338)
New parameter and improvement (#333)
New Functions for registry optimisation (#335)
Add autounattend.xml download if missing (#305)
autounattend.xml. If the file is not found, download it from a specified URL usingInvoke-RestMethodand save it to the script's root directory. This ensures the configuration file is available for the script's execution.Auto Dismount (#335)
Update PackagesToRemove with new ones
$packagePrefixes.$packagePrefixesto better lisibility.where-objectquery param from-like "$_*"to-like "*$_*"Others
README.mdfor clarity and added new features. (No msstore source (Microsoft Store not working, winget partially working) #316 (reply in thread)) [DOCS] Execution Policy Override #374We can add more
- Fixif you find some opened issues that are related to these ones.Reviews are gladly welcome ! Let me know if there is some thing to modify.
PS: I've seen some error related with the registry keys, but im not too familiar with it, seem some key does not existe in my reg but mabye is useful for some windows edition... but noting critical. tiny11iso is fine.