chore: Replace deprecated utcnow()#823
Conversation
771e4f4 to
e3258b0
Compare
|
@willingc do you have time to take a look at this tiny change? it would safe us a few deprecation warnings in our logs 🙂 |
|
@MSeal do you have time to take a look at this? |
rgbkrk
left a comment
There was a problem hiding this comment.
Thank you. Not sure what's up with CI not reporting back.
e3258b0 to
54f3d76
Compare
|
I tried to trigger CI with another push but it doesn't seem to help 🤷 |
|
https://github.com/nteract/papermill/actions/runs/19180999485 displays
|
|
Odd that can't trigger it from here. When I get back to my laptop I'll change the repo settings to modern GitHub actions so we can kick this off and clean up the backlog of PRs. |
|
according to https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks, there should be an approve button here on the conversations tab though I'm not sure where or how it looks like |
|
I took a look at the failing tests but the error doesn't seem related to the changes here:
|
|
ah, there is already an open issue for that: #825 |
|
Alright, I think you can now rebase this PR. |
see warning in Python documentation: https://docs.python.org/3.9/library/datetime.html#datetime.datetime.utcnow
for more information, see https://pre-commit.ci
54f3d76 to
9a723b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
- Coverage 91.54% 90.99% -0.56%
==========================================
Files 17 17
Lines 1621 1632 +11
==========================================
+ Hits 1484 1485 +1
- Misses 137 147 +10
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Thank you again @winniehell! |

What does this PR do?
replace
datetime.datetime.utcnow()withdatetime.datetime.now(datetime.timezone.utc)to resolve deprecation warningssee warning in Python documentation: https://docs.python.org/3.8/library/datetime.html#datetime.datetime.utcnow