feat: bump oxfmt to v0.26.0#4
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a shared JSON schema and consolidates oxfmt options into a FormatConfig with per-file overrides; expands formatting options (HTML/Vue/prose, import/package.json/Tailwind sorting, objectWrap, ignorePatterns); updates type declarations, tests, README, and bumps several package/devDependency versions. Changes
Sequence Diagram(s)(Skipped — changes are schema/options and do not introduce a multi-component sequential flow.) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
59-62: peerDependenciesoxfmtversion should be bumped to match devDependencies.The PR description indicates support for new v0.26.0 options (
experimentalSortImports.customGroups,sortScripts,htmlWhitespaceSensitivity,proseWrap,vueIndentScriptAndStyle,overrides), butpeerDependenciesstill requires^0.24.0. Users installing this plugin with oxfmt v0.24.x may encounter runtime errors when using these new features.Proposed fix
"peerDependencies": { "eslint": "^9.5.0", - "oxfmt": "^0.24.0" + "oxfmt": "^0.26.0" },
There was a problem hiding this comment.
Pull request overview
This pull request bumps the oxfmt formatter from v0.24.0 to v0.26.0 along with updating related dependencies. The PR description indicates intent to add support for six new configuration options, but these remain unimplemented.
Changes:
- Update oxfmt from ^0.24.0 to ^0.26.0 in devDependencies
- Update load-oxfmt-config from ^0.0.6 to ^0.0.7
- Update synckit from ^0.11.11 to ^0.11.12
- Update various other development dependencies (vitest, prettier, bumpp, @types/node, @typescript/native-preview)
- Update package manager version from pnpm@10.28.0 to pnpm@10.28.1
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates oxfmt to v0.26.0 in devDependencies, updates load-oxfmt-config, synckit, and other dev dependencies; bumps package manager version |
| pnpm-lock.yaml | Reflects all dependency version updates with corresponding lockfile changes including transitive dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
77fa693 to
74e5225
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/rules/oxfmt.ts (1)
30-78: Implement override resolution logic before passing options to oxfmt.oxfmt's API does not support
overridesas a programmatic option—per-file formatting requires separate API calls with differentFormatOptionsper file. The rule exposesoverridesin its schema but currently passes all options directly to the worker without resolving file-specific overrides. This will cause overrides to be silently ignored. The rule must match files against override glob patterns and invoke the worker multiple times with appropriate options per file, or removeoverridesfrom the schema if not implemented.
experimentalSortImports.customGroupsexperimentalSortPackageJson.sortScriptshtmlWhitespaceSensitivityproseWrapvueIndentScriptAndStyleoverridesSummary by CodeRabbit
New Features
Documentation
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.