Fix CMake compatibility with modern CMake (>= 4.0) - #1238
Merged
Conversation
- Move cmake_minimum_required() before project() as required - Bump minimum version from 2.6 to 3.5 (CMake 4.0 dropped support for < 3.5) - Use 3.5...3.31 version range to indicate the project works with policies up to CMake 3.31 while keeping 3.5 as the floor Made-with: Cursor
Author
|
@lucaderi this one could potentially be the last one as I noticed that after merging to |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0-stable #1238 +/- ##
==============================================
+ Coverage 18.31% 21.38% +3.07%
==============================================
Files 41 45 +4
Lines 8589 9161 +572
Branches 0 1235 +1235
==============================================
+ Hits 1573 1959 +386
- Misses 7016 7202 +186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@lucaderi Hi Luca, this is a nice to have :-) Ez to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CMake workflow (
cmake-linux.yml) fails onmacos-latestbecause the runner now ships CMake 4.x, which dropped compatibility with versions below 3.5.Two issues in
CMakeLists.txt:project()was called beforecmake_minimum_required()— CMake requires the opposite ordercmake_minimum_required(VERSION 2.6)— version 2.6 is rejected by CMake >= 4.0Fix
cmake_minimum_required()comes firstVERSION 3.5...3.31range syntax: floor of 3.5 (oldest CMake still supported by modern CMake) with policies up to 3.31Before
After
Test plan