Revert refactoring of duplicated get_*_sys function implementations#79
Closed
Revert refactoring of duplicated get_*_sys function implementations#79
Conversation
Co-authored-by: sosiristseng <40054455+sosiristseng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code to improve maintainability
Refactor duplicated get_*_sys function implementations
Nov 13, 2025
Member
|
@copilot Sorry but please remove the PR |
Co-authored-by: sosiristseng <40054455+sosiristseng@users.noreply.github.com>
Author
Copilot
AI
changed the title
Refactor duplicated get_*_sys function implementations
Revert refactoring of duplicated get_*_sys function implementations
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated code duplication across 12 subsystem functions that followed an identical pattern for creating ODESystem instances.All refactoring changes have been reverted as requested.
Changes
create_systemhelper function fromutils.jlconst System = ODESystemalias from main moduleget_*_sysfunctions@independent_variables tdeclaration inget_etc_sysFiles Restored
All changes to the following files have been reverted:
src/ECMEDox.jlsrc/utils.jlsrc/ck.jlsrc/nakpump.jlsrc/ina.jlsrc/force.jlsrc/ik2009.jlsrc/ica.jlsrc/ros.jlsrc/tca.jlsrc/transmito.jlsrc/cicr16.jlsrc/oxphos.jlThe codebase is now identical to its state before the refactoring was attempted.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.