Adapt abbreviation algorithm to not visit complete mismatch structures #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the experimental abbreviation feature on a list of datomic entities and noticed some new exceptions.
Datomic entities are tricky to work with in the presence of
clojure.walk
functions because you can't assoc/cons onto them. Generally matcher-combinators doesn't work too well on them but because of this.In this particular case, I realized that it was because the walk was descending into missing/unexpected data, which shouldn't be abbreviated at all. If that data is a datomic entity, it raises an exception. So to avoid such exceptions, and data traversal, I added a patched version of prewalk that allows not descending into elements that satisfy a predicate.