Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clojure tools versions #220

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

gilvan-reis
Copy link
Member

@gilvan-reis gilvan-reis commented Feb 8, 2024

Even after adding the license to the POM file, we still can not deploy to clojars.

After some analysis, I discovered the problem was related to the tools.deps version (0.16.1264) being used that does not support the usage of the :pom-data.

So I'm bumping the tools.build version to generate the correct POM file. I could verify that everything was correct by executing bb jar and checking the file on target/classes/META-INF/maven/nubank/matcher-combinators/pom.xml

Copy link

@scottbale scottbale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any problems with bumping this dep, LGTM.

@philomates
Copy link
Collaborator

so it required a version downgrade of tools.deps? If the build runs, then :shipit:
thanks for investigating

@gilvan-reis gilvan-reis merged commit beae388 into master Feb 8, 2024
2 checks passed
@gilvan-reis gilvan-reis deleted the upgrade-clojure-tools-version branch February 8, 2024 17:32
@gilvan-reis
Copy link
Member Author

@philomates Actually it was a upgrade of tools.deps from 0.16.1264 to 0.18.1354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants