Moved version in CMakeLists#221
Closed
GGsrvg wants to merge 27 commits into
Closed
Conversation
Contributor
Author
|
here you can see how checking works https://github.com/GGsrvg/kiwi/actions/workflows/validateTag.yml |
Qix-
reviewed
Mar 16, 2026
| - name: Delete tag if version mismatch | ||
| if: failure() | ||
| run: | | ||
| git push --delete origin ${{ steps.tag.outputs.tag_name }} |
Contributor
There was a problem hiding this comment.
This is a red flag, GHA's should not be deleting remote objects etc. Is this file AI generated?
Contributor
Author
There was a problem hiding this comment.
Which verification option would be better in this case?
Contributor
Author
There was a problem hiding this comment.
Is this file AI generated?
I don't use agent mode. Since I don't know much about GHA, I used gpt to clarify the information.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 82.29% 81.45% -0.85%
==========================================
Files 24 24
Lines 1785 1736 -49
Branches 242 240 -2
==========================================
- Hits 1469 1414 -55
- Misses 172 179 +7
+ Partials 144 143 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing #220