Add support for symfony 8

.github/workflows/continuous-integration.yml

@@ -13,5 +13,6 @@ jobs:
     uses: "nucleos/actions/.github/workflows/continuous-integration.yml@main"
     with:
       PHP_EXTENSIONS: ""
+      SYMFONY_VERSIONS: "7.4,8.0"
     secrets:
       CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"

composer.json

@@ -39,25 +39,25 @@
         "php": "^8.1",
         "ext-json": "*",
         "ext-pcre": "*",
-        "symfony/form": "^6.4 || ^7.0",
-        "symfony/http-foundation": "^6.4 || ^7.0",
-        "symfony/options-resolver": "^6.4 || ^7.0",
-        "symfony/property-access": "^6.4 || ^7.0",
-        "symfony/translation": "^6.4 || ^7.0",
-        "symfony/validator": "^6.4 || ^7.0"
+        "symfony/form": "^7.4 || ^8.0",
+        "symfony/http-foundation": "^7.4 || ^8.0",
+        "symfony/options-resolver": "^7.4 || ^8.0",
+        "symfony/property-access": "^7.4 || ^8.0",
+        "symfony/translation": "^7.4 || ^8.0",
+        "symfony/validator": "^7.4 || ^8.0"
     },
     "require-dev": {
         "doctrine/doctrine-bundle": "^2.18 || ^3.0",
         "doctrine/orm": "^2.5 || ^3.0",
         "doctrine/persistence": "^3.0 || ^4.0",
         "ergebnis/composer-normalize": "^2.0.1",
-        "symfony/browser-kit": "^6.4 || ^7.0",
-        "symfony/config": "^6.4 || ^7.0",
-        "symfony/dependency-injection": "^6.4 || ^7.0",
-        "symfony/expression-language": "^6.4 || ^7.0",
-        "symfony/framework-bundle": "^6.4 || ^7.0",
-        "symfony/http-kernel": "^6.4 || ^7.0",
-        "symfony/twig-bridge": "^6.4 || ^7.0",
+        "symfony/browser-kit": "^7.4 || ^8.0",
+        "symfony/config": "^7.4 || ^8.0",
+        "symfony/dependency-injection": "^7.4 || ^8.0",
+        "symfony/expression-language": "^7.4 || ^8.0",
+        "symfony/framework-bundle": "^7.4 || ^8.0",
+        "symfony/http-kernel": "^7.4 || ^8.0",
+        "symfony/twig-bridge": "^7.4 || ^8.0",
         "twig/intl-extra": "^2.4 || ^3.0"
     },
     "conflict": {

src/Type/TimePickerType.php

@@ -88,6 +88,8 @@ static function ($c) {
                     $dpKey
                 );
 
+                \assert(null !== $dpKey);
+
                 $dpOptions[$dpKey] = $value;
             }
         }

src/Validator/Constraints/BatchTimeAfter.php

@@ -14,6 +14,7 @@
 use Attribute;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Exception\InvalidOptionsException;
+use Symfony\Component\Validator\Exception\MissingOptionsException;
 
 /**
  * @Annotation
@@ -48,6 +49,8 @@ final class BatchTimeAfter extends Constraint
     public $required = true;
 
     /**
+     * @SuppressWarnings("PHPMD.NPathComplexity")
+     *
      * @param array<string, mixed> $options
      */
     public function __construct(
@@ -75,6 +78,18 @@ public function __construct(
         $this->emptyMessage = $emptyMessage ?? $this->emptyMessage;
         $this->required     = $required     ?? $this->required;
 
+        if (null === $this->firstField) {
+            throw new MissingOptionsException('The options "firstField" must be set for constraint "'.__CLASS__.'".', [
+                'firstField',
+            ]);
+        }
+
+        if (null === $this->secondField) {
+            throw new MissingOptionsException('The options "secondField" must be set for constraint "'.__CLASS__.'".', [
+                'secondField',
+            ]);
+        }
+
         if ($this->firstField === $this->secondField) {
             throw new InvalidOptionsException('The options "firstField" and "secondField" can not be the same for constraint '.__CLASS__, [
                 'firstField',
@@ -83,6 +98,9 @@ public function __construct(
         }
     }
 
+    /**
+     * @return string[]
+     */
     public function getRequiredOptions(): array
     {
         return [

src/Validator/Constraints/DateAfter.php

@@ -14,6 +14,7 @@
 use Attribute;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Exception\InvalidOptionsException;
+use Symfony\Component\Validator\Exception\MissingOptionsException;
 
 /**
  * @Annotation
@@ -48,6 +49,8 @@ final class DateAfter extends Constraint
     public $required = true;
 
     /**
+     * @SuppressWarnings("PHPMD.NPathComplexity")
+     *
      * @param array<string, mixed> $options
      */
     public function __construct(
@@ -75,6 +78,18 @@ public function __construct(
         $this->emptyMessage = $emptyMessage ?? $this->emptyMessage;
         $this->required     = $required     ?? $this->required;
 
+        if (null === $this->firstField) {
+            throw new MissingOptionsException('The options "firstField" must be set for constraint "'.__CLASS__.'".', [
+                'firstField',
+            ]);
+        }
+
+        if (null === $this->secondField) {
+            throw new MissingOptionsException('The options "secondField" must be set for constraint "'.__CLASS__.'".', [
+                'secondField',
+            ]);
+        }
+
         if ($this->firstField === $this->secondField) {
             throw new InvalidOptionsException('The options "firstField" and "secondField" can not be the same for constraint '.__CLASS__, [
                 'firstField',
@@ -83,6 +98,9 @@ public function __construct(
         }
     }
 
+    /**
+     * @return string[]
+     */
     public function getRequiredOptions(): array
     {
         return [

tests/Validator/Constraints/BatchTimeAfterTest.php

@@ -23,49 +23,49 @@ public function testItIsNotInstantiableWithMissingFirstField(): void
         $this->expectException(MissingOptionsException::class);
         $this->expectExceptionMessageMatches(\sprintf('#^%s#', preg_quote('The options "firstField" must be set for constraint', '#')));
 
-        new BatchTimeAfter([
-            'secondField' => 'first',
-        ]);
+        new BatchTimeAfter(
+            secondField : 'first',
+        );
     }
 
     public function testItIsNotInstantiableWithMissingSecondField(): void
     {
         $this->expectException(MissingOptionsException::class);
         $this->expectExceptionMessageMatches(\sprintf('#^%s#', preg_quote('The options "secondField" must be set for constraint', '#')));
 
-        new BatchTimeAfter([
-            'firstField' => 'first',
-        ]);
+        new BatchTimeAfter(
+            firstField : 'first',
+        );
     }
 
     public function testItIsNotInstantiableWithSameField(): void
     {
         $this->expectException(InvalidOptionsException::class);
         $this->expectExceptionMessage('The options "firstField" and "secondField" can not be the same for constraint '.BatchTimeAfter::class);
 
-        new BatchTimeAfter([
-            'firstField'  => 'first',
-            'secondField' => 'first',
-        ]);
+        new BatchTimeAfter(
+            firstField  : 'first',
+            secondField : 'first',
+        );
     }
 
     public function testItIsInstantiable(): void
     {
-        $dateAfter = new BatchTimeAfter([
-            'firstField'  => 'first',
-            'secondField' => 'second',
-        ]);
+        $dateAfter = new BatchTimeAfter(
+            firstField  : 'first',
+            secondField : 'second',
+        );
 
         self::assertSame('first', $dateAfter->firstField);
         self::assertSame('second', $dateAfter->secondField);
     }
 
     public function testGetTarget(): void
     {
-        $dateAfter = new BatchTimeAfter([
-            'firstField'  => 'first',
-            'secondField' => 'second',
-        ]);
+        $dateAfter = new BatchTimeAfter(
+            firstField  : 'first',
+            secondField : 'second',
+        );
 
         self::assertSame('class', $dateAfter->getTargets());
     }