Skip to content

[Utils] Implement helpers to remove dependencies#4

Merged
TomerShor merged 2 commits intonuclio:mainfrom
TomerShor:remove-common
Jul 3, 2025
Merged

[Utils] Implement helpers to remove dependencies#4
TomerShor merged 2 commits intonuclio:mainfrom
TomerShor:remove-common

Conversation

@TomerShor
Copy link
Contributor

  • Importing nuclio/nuclio brought some extra unneeded dependecies
  • This Package is to be imported in nuclio/nuclio, so we should remove it to avoid circular imports
  • Implement helper functions - retryUntilSuccessful and sendHTTPRequest - private methods so they won't be used externally.
  • Some other cleanups wrt to external packages

Copy link

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just minor

@TomerShor TomerShor merged commit 9f6514b into nuclio:main Jul 3, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants