Skip to content

Conversation

@KeranYang
Copy link
Member

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a2c51c2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage        ?   58.74%           
  Complexity      ?      384           
=======================================
  Files           ?      127           
  Lines           ?     2831           
  Branches        ?      179           
=======================================
  Hits            ?     1663           
  Misses          ?     1052           
  Partials        ?      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeranYang KeranYang marked this pull request as ready for review January 22, 2025 15:32
Copy link

@Krithika3 Krithika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure that we need to test this out before releasing or any e2e tests will be good? Thank you

@KeranYang
Copy link
Member Author

@Krithika3 yes, unit tests are all good. I will merge this in and e2e test it.

@KeranYang KeranYang merged commit 38be808 into main Jan 22, 2025
5 checks passed
@KeranYang KeranYang deleted the vul branch January 22, 2025 18:30
@KeranYang
Copy link
Member Author

@Krithika3 Triggered the e2e test suites and tests all passed with the updated images. https://github.com/numaproj/numaflow/actions/runs/12911381831/job/36015607270?pr=2352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix vulnerability issue from protobuf-java 3.21.8

3 participants