Skip to content

chore: formalize gRPC errors in case of UDF exceptions #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adarsh0728 merged 8 commits into from
Feb 13, 2025
Merged

chore: formalize gRPC errors in case of UDF exceptions #166

adarsh0728 merged 8 commits into from
Feb 13, 2025

Conversation

@adarsh0728
Copy link
Member

@adarsh0728 adarsh0728 commented Feb 5, 2025 •
edited
Loading

fixes: #165

@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@097467c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ain/java/io/numaproj/numaflow/sourcer/Service.java 33.33% 8 Missing ⚠️
...main/java/io/numaproj/numaflow/sinker/Service.java 75.00% 1 Missing and 1 partial ⚠️
...java/io/numaproj/numaflow/batchmapper/Service.java 87.50% 0 Missing and 1 partial ⚠️
...o/numaproj/numaflow/mapper/MapSupervisorActor.java 87.50% 0 Missing and 1 partial ⚠️
...va/io/numaproj/numaflow/shared/ExceptionUtils.java 83.33% 1 Missing ⚠️
...in/java/io/numaproj/numaflow/sideinput/Server.java 50.00% 0 Missing and 1 partial ⚠️
...n/java/io/numaproj/numaflow/sideinput/Service.java 66.66% 0 Missing and 1 partial ⚠️
...ow/sourcetransformer/TransformSupervisorActor.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   58.00%           
  Complexity      ?      392           
=======================================
  Files           ?      130           
  Lines           ?     2941           
  Branches        ?      186           
=======================================
  Hits            ?     1706           
  Misses          ?     1114           
  Partials        ?      121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adarsh0728 adarsh0728 marked this pull request as ready for review February 9, 2025 15:09
@adarsh0728 adarsh0728 requested a review from yhl25 February 9, 2025 15:09
KeranYang
KeranYang approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@KeranYang KeranYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments.

src/main/java/io/numaproj/numaflow/shared/ExceptionUtils.java
public static final String ERR_SINK_EXCEPTION = "UDF_EXECUTION_ERROR(sink)";
public static final String ERR_MAP_STREAM_EXCEPTION = "UDF_EXECUTION_ERROR(mapstream)";
public static final String ERR_MAP_EXCEPTION = "UDF_EXECUTION_ERROR(map)";
public static final String ERR_BATCH_MAP_EXCEPTION = "UDF_EXECUTION_ERROR(batchmap)";
Copy link
Member

@KeranYang KeranYang Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we skipping reducers?

Copy link
Member Author

@adarsh0728 adarsh0728 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for now (to be taken up later across sdk's) numaproj/numaflow-go#173 (comment)

src/main/java/io/numaproj/numaflow/sideinput/Server.java
/**
* Stop serving requests and shutdown resources. Await termination on the main thread since the
* Stop serving requests and shutdown resources. Await termination on the main
* thread since the
Copy link
Member

@KeranYang KeranYang Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the reformatting right? it seems we are getting more lines but short.

Copy link
Member Author

@adarsh0728 adarsh0728 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check why this was happening, reverted at most of the places.

src/test/java/io/numaproj/numaflow/shared/ExceptionUtilsTest.java
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertEquals;

public class ExceptionUtilsTest {
Copy link
Member

@KeranYang KeranYang Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

yhl25
yhl25 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please resolve the conflicts.

@adarsh0728
resolve conflicts
3773b9d 
Signed-off-by: adarsh0728 <[email protected]>
@adarsh0728 adarsh0728 merged commit d1cdb8f into main Feb 13, 2025
5 checks passed
@adarsh0728 adarsh0728 deleted the err-streamlining branch February 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KeranYang KeranYang KeranYang approved these changes

@yhl25 yhl25 yhl25 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add common prefix and formalize error messages

4 participants

@adarsh0728 @KeranYang @yhl25