Skip to content

fix: Sourcer - Avoid awaiting pending/partitions handlers #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BulkBeing wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Sourcer - Avoid awaiting pending/partitions handlers #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b47e07
Sourcer - Bug fixes
BulkBeing Dec 19, 2025
6b9dd50
convert all Sourcer methods to async
BulkBeing Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/pynumaflow/pynumaflow/sourcer/_dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def __init__(
payload: bytes,
offset: Offset,
event_time: datetime,
keys: list[str] = None,
keys: Optional[list[str]] = None,
headers: Optional[dict[str, str]] = None,
user_metadata: Optional[UserMetadata] = None,
):
Expand Down Expand Up @@ -261,12 +261,6 @@ class Sourcer(metaclass=ABCMeta):

"""

def __call__(self, *args, **kwargs):
"""
Allow to call handler function directly if class instance is sent
"""
return self.handler(*args, **kwargs)

@abstractmethod
async def read_handler(self, datum: ReadRequest, output: NonBlockingIterator):
"""
Expand All @@ -278,28 +272,28 @@ async def read_handler(self, datum: ReadRequest, output: NonBlockingIterator):
pass

@abstractmethod
def ack_handler(self, ack_request: AckRequest):
async def ack_handler(self, ack_request: AckRequest):
"""
The ack handler is used to acknowledge the offsets that have been read
"""
pass

@abstractmethod
def nack_handler(self, nack_request: NackRequest):
async def nack_handler(self, nack_request: NackRequest):
"""
The nack handler is used to negatively acknowledge the offsets on the source
"""
pass

@abstractmethod
def pending_handler(self) -> PendingResponse:
async def pending_handler(self) -> PendingResponse:
"""
The simple source always returns zero to indicate there is no pending record.
"""
pass

@abstractmethod
def partitions_handler(self) -> PartitionsResponse:
async def partitions_handler(self) -> PartitionsResponse:
"""
The simple source always returns zero to indicate there is no pending record.
"""
Expand Down
4 changes: 2 additions & 2 deletions packages/pynumaflow/pynumaflow/sourcer/servicer/async_servicer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ async def PendingFn(
except BaseException as err:
_LOGGER.critical("PendingFn Error", exc_info=True)
await handle_async_error(context, err, ERR_UDF_EXCEPTION_STRING)
return
raise
Copy link
Member

@vigith vigith Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise

handle_async_error will pkill, i don't think you need return or raise

resp = source_pb2.PendingResponse.Result(count=count.count)
return source_pb2.PendingResponse(result=resp)

Expand All @@ -228,7 +228,7 @@ async def PartitionsFn(
except BaseException as err:
_LOGGER.critical("PartitionsFn Error", exc_info=True)
await handle_async_error(context, err, ERR_UDF_EXCEPTION_STRING)
return
raise
resp = source_pb2.PartitionsResponse.Result(partitions=partitions.partitions)
return source_pb2.PartitionsResponse(result=resp)

Expand Down