chore(perf): Avoid message cloning in Sink#3203
Merged
Merged
Conversation
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
- Coverage 80.26% 80.24% -0.02%
==========================================
Files 297 297
Lines 67639 67640 +1
==========================================
- Hits 54289 54281 -8
- Misses 12802 12811 +9
Partials 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
vigith
changed the title
vigith
reviewed
Feb 6, 2026
Comment on lines
+103
to
+104
| // Don't increment i here, since we swapped the element at i with the last element | ||
| messages_to_retry.swap_remove(i); |
Member
There was a problem hiding this comment.
won't we lose ordering because of replace with the last element during unhappy path?
Contributor
Author
There was a problem hiding this comment.
Yes.. Should we preserve the order ?
Member
There was a problem hiding this comment.
Yes, because during retries, we do not want to switch semantics to unordered.
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
vigith
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Avoids cloning the messages in Sink wherever possible.
Testing
Tested manually by sending 100,000 messages and validating all messages on the Sink side.