feat: add platform-wide NUMAFLOW_LOG_LEVEL support#3410
feat: add platform-wide NUMAFLOW_LOG_LEVEL support#3410adarsh0728 wants to merge 2 commits intomainfrom
NUMAFLOW_LOG_LEVEL support#3410Conversation
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
+ Coverage 82.58% 82.69% +0.11%
==========================================
Files 307 308 +1
Lines 75655 76141 +486
==========================================
+ Hits 62476 62963 +487
+ Misses 12621 12619 -2
- Partials 558 559 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: NUMAFLOW_LOG_LEVEL | ||
| value: warn |
There was a problem hiding this comment.
I think we should just use DAEMON_LOG_LEVEL and not NUMAFLOW_LOG_LEVEL
There was a problem hiding this comment.
Should we explicitly mention CONTROLLER_LOG_LEVEL(daemon, controller etc) and DATAPLANE_LOG_LEVEL (should work like RUST_LOG)
There was a problem hiding this comment.
I think a single variable would be better, like NUMAFLOW_LOG_LEVEL.
We won't need to use DAEMON_LOG and NUMAFLOW_LOG at the same time for a single container anyway right?
Even if there is a situation like this, what do you think about treating them like components/modules and use Rust's log/tracing syntax:
NUMAFLOW_LOG_LEVEL=debug,builtin_udf=warn
There was a problem hiding this comment.
makes sense, lets go with one single log level env.
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
NUMAFLOW_LOG_LEVEL support for Go components and document runtime-specific log level controlsNUMAFLOW_LOG_LEVEL support
What this PR does / why we need it
NUMAFLOW_LOG_LEVELsupport for Go components using zap log levels.