Skip to content

feat: add platform-wide NUMAFLOW_LOG_LEVEL support#3410

Draft
adarsh0728 wants to merge 2 commits intomainfrom
feat/numaflow-log-level-env
Draft

feat: add platform-wide NUMAFLOW_LOG_LEVEL support#3410
adarsh0728 wants to merge 2 commits intomainfrom
feat/numaflow-log-level-env

Conversation

@adarsh0728
Copy link
Copy Markdown
Member

@adarsh0728 adarsh0728 commented May 7, 2026

What this PR does / why we need it

  • Users need a way to raise log levels for daemon and controller pods to reduce log noise.
  • Adds NUMAFLOW_LOG_LEVEL support for Go components using zap log levels.
  • Documents Go and Rust log-level controls, including examples for daemon, controller, webhook, server, ISB jobs, vertex, MonoVertex.
  • Moves noisy idle MonoVertex rater metric logs from info to debug.

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.69%. Comparing base (284552f) to head (4e5c520).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow/src/setup_tracing.rs 92.45% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
+ Coverage   82.58%   82.69%   +0.11%     
==========================================
  Files         307      308       +1     
  Lines       75655    76141     +486     
==========================================
+ Hits        62476    62963     +487     
+ Misses      12621    12619       -2     
- Partials      558      559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +58 to +59
- name: NUMAFLOW_LOG_LEVEL
value: warn
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just use DAEMON_LOG_LEVEL and not NUMAFLOW_LOG_LEVEL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly mention CONTROLLER_LOG_LEVEL(daemon, controller etc) and DATAPLANE_LOG_LEVEL (should work like RUST_LOG)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a single variable would be better, like NUMAFLOW_LOG_LEVEL.
We won't need to use DAEMON_LOG and NUMAFLOW_LOG at the same time for a single container anyway right?

Even if there is a situation like this, what do you think about treating them like components/modules and use Rust's log/tracing syntax:

NUMAFLOW_LOG_LEVEL=debug,builtin_udf=warn

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lets go with one single log level env.

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@adarsh0728 adarsh0728 changed the title feat: Add NUMAFLOW_LOG_LEVEL support for Go components and document runtime-specific log level controls feat: add platform-wide NUMAFLOW_LOG_LEVEL support May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants