fix: send explicit eot from stream receiver task to stream execute task#3418
Draft
vaibhavtiwari33 wants to merge 3 commits intomainfrom
Draft
fix: send explicit eot from stream receiver task to stream execute task#3418vaibhavtiwari33 wants to merge 3 commits intomainfrom
vaibhavtiwari33 wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
+ Coverage 82.64% 82.68% +0.03%
==========================================
Files 307 307
Lines 76051 76089 +38
==========================================
+ Hits 62853 62911 +58
+ Misses 12645 12620 -25
- Partials 553 558 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n cancellation token in execute loop Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Whenever the stream receiver task, a single task responsible for receiving responses from udf server and streaming them back to the respective execute tasks, drops the sender used for streaming back responses to execute tasks; the execute tasks see that as a signal that all the responses have been sent by the receiver task.
We should send an explicit EOT from from the receiver task to let the execute task know that we're done sending responses.
Related issues
Fixes #3417
Testing
Special notes for reviewers
Anything notable for review (risk, rollout, follow-ups).