feat: add udf shared helpers and resilient error persistence#3459
Merged
Conversation
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
- Coverage 82.68% 82.66% -0.02%
==========================================
Files 307 307
Lines 77569 77912 +343
==========================================
+ Hits 64135 64407 +272
- Misses 12876 12948 +72
+ Partials 558 557 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
yhl25
reviewed
Jun 9, 2026
Comment on lines
+219
to
+235
| /// Reconnects to a user-defined sink sidecar. See [`reconnect_source`] for the reconnect sequence. | ||
| #[allow(dead_code)] | ||
| pub(crate) async fn reconnect_sink( | ||
| socket_path: PathBuf, | ||
| server_info_path: PathBuf, | ||
| cln_token: CancellationToken, | ||
| grpc_max_message_size: usize, | ||
| retry_interval: Duration, | ||
| ) -> error::Result<SinkClient<Channel>> { | ||
| let channel = create_rpc_channel_with_interval(socket_path, retry_interval).await?; | ||
| let mut client = SinkClient::new(channel) | ||
| .max_encoding_message_size(grpc_max_message_size) | ||
| .max_decoding_message_size(grpc_max_message_size); | ||
| wait_until_sink_ready(&cln_token, &mut client).await?; | ||
| let _server_info = sdk_server_info(server_info_path, cln_token.clone()).await?; | ||
| Ok(client) | ||
| } |
Contributor
There was a problem hiding this comment.
why a separate method for reconnect? can we just use the existing connect method or call it create_sink_client? similarly for other clients as well.
Member
Author
There was a problem hiding this comment.
will use create_sink_client and similar naming for other components
Member
Author
There was a problem hiding this comment.
added different clients (will be used at startup and reconnect) , may be can add a common helper like create_udf_client to avoid duplication of logic inside those helpers.. but current helpers look simple and readabale.
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
adarsh0728
changed the title
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
yhl25
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces shared helpers, UDF-specific error classification, and safer runtime error persistence. The actual source/transformer/map/sink reconnect behaviour will be wired in follow-up PRs.
Related Issues
#3368
What Changed
create_*_clienthelpers for source, sink, source transformer, and mapper UDF clients.Behaviour Change