Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move llvmlite to llvm19 #1092

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Move llvmlite to llvm19 #1092

wants to merge 20 commits into from

Conversation

yashssh
Copy link
Contributor

@yashssh yashssh commented Oct 25, 2024

Depends and contains changes introduced with #1091

List of changes in this MR

  • Delete legacy pass manager code
  • Delete typed pointer code
  • Update APIs that needs updating for llvm19
  • Update refprune pass and its tests

TODO:

  • run with remarks feature and pass timer features have to be added

yashssh and others added 20 commits August 22, 2024 12:43
@yashssh
Use C-macros to register passes and prevent duplication in c++ files
399dbeb 
Add todo for future passes, simplify pass registeration in newpassmanager.py

add dot printer passes

Add hooks for most of the passes currently supported by legacy pm

edit
@yashssh
Fix working of new APIs with llvm16, add a printer pass
cd8defc
@rj-jesus
Merge branch 'rjj/enable-opaque-pointers' into nvmain
cc9991c
@yashssh
Merge branch 'yashwants/npm-refprune' into nvmain
3c10473
@yashssh
Merge branch 'yashwants/npm-refprune' into nvmain
a9596be
@yashssh
Merge branch 'yashwants/npm-more-hooks' into nvmain
802c412
@yashssh
Move the APIs to llvm17
1e50a97 
Drop support for typed pointers
Drop support for Legacy pass managers
Update some APIs
@yashssh
Drop support of llvm<17
7c0eeb1 
- Delete transforms.{py|cpp}
- Drop support for llvm version < 17
- Refactoring
@yashssh
Drop passmanagers.{py|cpp}
0d4ecc3
@yashssh
more refactoring
3b40dc7
@yashssh
Merge branch 'yashwants/llvm17' into nvmain
d05a81c
@yashssh
fix syntax bugs
8ba6cca
@yashssh
Add initial support for llvm18
9d4490e 
- Fix some deprecated APIs
- Disable some refprune tests, either the tests or the pass itself needs updating for llvm18
@yashssh
Support building with llvm19
1d1b169 
- Update few APIs
@yashssh
Use C-macros to register passes and prevent duplication in c++ files
0ba654d 
Add todo for future passes, simplify pass registeration in newpassmanager.py

Add dot printer passes

Add hooks for most of the passes currently supported by legacy pm

Fix working of new APIs with llvm16
@yashssh
Fix broken includes
ae61097
@yashssh
Merge branch 'yashwants/npm-more-hooks' into yashwants/llvm19
c73d89b
@yashssh
update RISCV tests
2e0195c
@yashssh
Drop legacy pm support from refprune, update tests to avoid crashes o…
fac63a4 
…n llvm>-=18
@yashssh
python formatting
d1b10c6
@gmarkall
Copy link
Member

gmarkall commented Nov 5, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@yashssh yashssh mentioned this pull request Jan 8, 2025
Closed
rj-jesus
rj-jesus reviewed Jan 13, 2025
View reviewed changes
ffi/core.cpp
auto context = LLVMGetGlobalContext();
LLVMContextSetOpaquePointers(context, enableOpaquePointers);
// Opaque pointer support dropped https://reviews.llvm.org/D139441
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you meant "Typed pointer support dropped"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thanks for spotting! Will update :)

rj-jesus
rj-jesus reviewed Jan 13, 2025
View reviewed changes
ffi/core.cpp
LLVMContextRef context = LLVMContextCreate();
LLVMContextSetOpaquePointers(context, enableOpaquePointers);
// Opaque pointer support dropped https://reviews.llvm.org/D139441
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as above.)

@BwL1289 BwL1289 mentioned this pull request Jan 21, 2025
Open
@detrout
Copy link

detrout commented Mar 3, 2025

Hi,

I found time to try and work on getting llvmlite to build with a version of llvm that's in Debian.

I took this pull request and rebased it against 0.44.0, and then collapse the branch into a single diff to apply to the a Debian 0.44.0 version of the llvmlite package.

I pushed what I've manage to get done to https://github.com/detrout/llvmlite/tree/llvm19

I noticed there's a bunch of code removed this pull request in a migration from passmanager to newpassmanager, though the llvmlite HEAD branch currently has both passmanager and newpassmanager modules. I don't know if it's intended to remove passmanager or not?

The merged code almost works (at least on Debian unstable on a x86 cpu with python 3.13.2 and llvm-19.1.7) it's down to two test failures.

======================================================================             
FAIL: test_object_file (llvmlite.tests.test_binding.TestObjectFile.test_object_file)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.13_llvmlite/build/llvmlite/tests/test_binding.py", line 2443, in test_object_file
    self.assertTrue(s.size() > 0)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
AssertionError: False is not true
                               
======================================================================
FAIL: test_lookup_current_process_symbol_fails (llvmlite.tests.test_binding.TestOrcLLJIT.test_lookup_current_process_symbol_fai
ls)                  
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.13_llvmlite/build/llvmlite/tests/test_binding.py", line 1493, in test_lookup_curre
nt_process_symbol_fails                                        
    with self.assertRaisesRegex(RuntimeError, msg):
         ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: RuntimeError not raised
                                                                                                                               
----------------------------------------------------------------------
Ran 379 tests in 7.699s

FAILED (failures=2, skipped=2)

I did try running the build under arm64 using qemu and funny story, all the tests passed.

Ran 379 tests in 171.947s
                               
OK (skipped=19)

@detrout
Copy link

detrout commented Mar 3, 2025

I'd also managed to run the two test failures in pdb, and for the llvmlite.tests.test_binding.TestObjectFile.test_object_file

I found a possibly useful thing that there was a .text segment that had no contents. Though there were other text segments like (I think) .ltext that had some contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rj-jesus rj-jesus rj-jesus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2 - In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashssh @gmarkall @detrout @rj-jesus