refactor llvmdev win builder #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esc
requested changes
Feb 1, 2025
There was a problem hiding this comment.
I have left a series of comments on the PR. In addition to those you will also need the following three changes:
-
Rename the file to match the pattern of the current workflows.
-
Rename the workflow itself to match the pattersn of the current workflows.
-
For this to be reusable, you'll need to echo out the the workflow ID like:
- name: Get Workflow Run ID
run: |
echo "Current workflow run ID: ${{ github.run_id }}"
echo "Use this ID when triggering llvmlite workflow"
Co-authored-by: Emergency Self-Construct <[email protected]>
Co-authored-by: Emergency Self-Construct <[email protected]>
|
I am merging this now, to get #1144 rolling 🛼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.