-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execute dist tests for linux-64 conda pkgs via Azure #1154
Conversation
As title
'libgcc_s', 'libc', 'ld-linux', 'ld64', 'libzstd', | ||
'libstdc++']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changed? Do the new libs require a change in the manylinux target platform for wheel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My current understanding is that this test has been dormat for many years. It was never run on the Anaconda internal build farm nor on Azure. The test requires setting of LLVMLITE_DIST_TEST=1
such that it runs and neither the build farm nor the Azure tests ran this.
This was discovered because the workflow at: #1132 uses conda build --test
(as pers suggestion from @stuartarchibald ) to run the test and that does:
import os
from llvmlite.tests import main
# Enable tests for distribution only
os.environ['LLVMLITE_DIST_TEST'] = '1'
main()
So basically, a dormant test has been discovered. The code probably changed in the meantime. This adapts the test such that it passes when run on main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: this is not related to wheel builds, but conda packages.
As title