-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opaque pointer fixes #1158
base: main
Are you sure you want to change the base?
Opaque pointer fixes #1158
Conversation
What are the issues? Are there any test cases that should be added to clarify / check that the issues are resolved? |
Hi @gmarkall, just added a few tests for this. I wasn't sure where to place them, so I created new methods for them. Please let me know if you have a better idea! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes look good to me. Approving and proceeding as per comments on diff inline.
This fixes a few issues @stuartarchibald and I found with opaque pointers.