Fix the metadata deduplication #1165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llvmlite debug metadata cache does not work as expected due to the encoding value using address of DIToken instance and serves as part of the key. Solutions could be either singleton the DIToken class, or extract the string value from the encoding object. Since the DIToken class is designed to be a wrapper of enumeration value, e.g. the DW_* enumerations, that should appear bare in the emitted metadata, in this change, singleton DIToken is made to fix the problem. This solves llvmlit issue numba#1164 numba#1164
The llvmlite debug metadata cache does not work as expected due to the encoding value using address of DIToken instance and serves as part of the key. Solution is to extract the string value from the encoding object. Since the DIToken class is designed to be a wrapper of enumeration value, e.g. the DW_* enumerations, that should appear bare in the emitted metadata, in this change, stringify DIToken is made to fix the problem. This solved llvmlite issue numba#1164
|
Could you add a test please? |
Yes, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvmlite debug metadata cache does not work as expected due to the encoding value using address of DIToken instance and serves as part of the key.
Solution is to extract the string value from the encoding object.
Since the DIToken class is designed to be a wrapper of enumeration value, e.g. the DW_* enumerations, that should appear bare in the emitted metadata, in this change, stringify DIToken is made to fix the problem.
This solves llvmlite issue #1164