Skip to content

Conversation

@ngoldbaum
Copy link

@ngoldbaum ngoldbaum commented Nov 3, 2025

Adds 3.14t to the wheel building matrix. Because PyLIEF doesn't yet ship cp314t wheels (lief-project/LIEF#1255) and PyLIEF doesn't list any build requirements in its pyproject.toml, it's necessary to set up the PyLIEF build manually.

Unfortunately this adds a decent amount of overhead to the builds, particularly for the Mac builds, where the PyLIEF build happens twice during the build and install steps. We could probably optimize that but I'm curious if the maintainers are opposed to this approach and would prefer I work on getting PyLIEF wheels ready instead.

@ngoldbaum
Copy link
Author

I ran the github actions tests on my fork, see the github actions tests associated with ngoldbaum@43c266b. As far as I can see, all the cp314t wheel builds complete successfully and the tests pass for all the builds that are tested.

@esc
Copy link
Member

esc commented Nov 3, 2025

@ngoldbaum thats awesome! So cool to see that it will work! I'll confer with the other maintainers during our weekly meet tomorrow and get back to you with suggestions for acceptability and best course of action. Thank you for helping to improve llvmlite.

@ngoldbaum
Copy link
Author

Hmm, spoke too soon, it looks like the Windows tests crashed. I'll see if I can reproduce the crash on my Windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants