Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses flake8 linting errors in the buildscripts identified in a failing pre-commit workflow. The changes focus on formatting improvements to comply with line length limits and Python style guidelines.
- Reformatted long lines to comply with flake8 line length requirements
- Improved code readability through multi-line formatting of long strings, function calls, and data structures
- Removed trailing newlines from file endings
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| buildscripts/github/validate_win-64_wheel.py | Reformatted set comprehension to split across multiple lines for readability |
| buildscripts/github/llvmlite_evaluate.py | Reformatted dictionary entries in the default_include list to multi-line format for improved readability |
| buildscripts/github/find_workflow_runs.py | Fixed multiple line-length violations by splitting long strings and function calls; removed trailing newline |
| buildscripts/github/download_artifacts.py | Fixed multiple line-length violations by splitting long strings and function calls; removed trailing newline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaning PR - addresses flake8 errors as seen on failing pre-commit workflow last release.
https://github.com/numba/llvmlite/actions/runs/20037244990