Skip to content

fix ci buildscripts for flake8 errors#1381

Merged
esc merged 2 commits intonumba:mainfrom
swap357:fix_lint_issues
Jan 6, 2026
Merged

fix ci buildscripts for flake8 errors#1381
esc merged 2 commits intonumba:mainfrom
swap357:fix_lint_issues

Conversation

@swap357
Copy link
Contributor

@swap357 swap357 commented Dec 11, 2025

cleaning PR - addresses flake8 errors as seen on failing pre-commit workflow last release.
https://github.com/numba/llvmlite/actions/runs/20037244990

@swap357 swap357 marked this pull request as ready for review December 12, 2025 16:43
@swap357 swap357 requested review from Copilot and esc December 15, 2025 16:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses flake8 linting errors in the buildscripts identified in a failing pre-commit workflow. The changes focus on formatting improvements to comply with line length limits and Python style guidelines.

  • Reformatted long lines to comply with flake8 line length requirements
  • Improved code readability through multi-line formatting of long strings, function calls, and data structures
  • Removed trailing newlines from file endings

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
buildscripts/github/validate_win-64_wheel.py Reformatted set comprehension to split across multiple lines for readability
buildscripts/github/llvmlite_evaluate.py Reformatted dictionary entries in the default_include list to multi-line format for improved readability
buildscripts/github/find_workflow_runs.py Fixed multiple line-length violations by splitting long strings and function calls; removed trailing newline
buildscripts/github/download_artifacts.py Fixed multiple line-length violations by splitting long strings and function calls; removed trailing newline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@esc esc modified the milestones: 0.46.0rc1, 0.47.0rc1 Jan 6, 2026
@esc esc merged commit 17c49d0 into numba:main Jan 6, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants