Add the ability to draw Gauss curves over histograms#2051
Open
WalrusGumboot wants to merge 5 commits intonumworks:masterfrom
Open
Add the ability to draw Gauss curves over histograms#2051WalrusGumboot wants to merge 5 commits intonumworks:masterfrom
WalrusGumboot wants to merge 5 commits intonumworks:masterfrom
Conversation
TODO: make UI pretty, scale curve according to data (absolute height vs relative height)
(this has the added bonus of being a bit more efficient)
|
|
WalrusGumboot
commented
May 1, 2023
Author
WalrusGumboot
left a comment
WalrusGumboot
left a comment
There was a problem hiding this comment.
oh yeah also this fixes a typo in the i18n; BarStartDescrition is now BarStartDescription
Collaborator
|
Hi @WalrusGumboot, |
|
@WalrusGumboot Just FYI, this is not an open-source project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone! This is my first ever pull request on any major open source project, so I'm super excited for it.
For a bit of context: in a stats lesson, my maths teacher said something along the lines of "the only advantage your old TI-84s have over the Numworks that all other students have, is that you're able to draw a Gauss curve over a histogram, to check if the data is normally distributed. Astounded that this wasn't possible in the current version of the software, I decided to try adding it.
I should note that I'm not very acquainted with C++; I mainly write Rust, and in thinking "well, they're both systems languages, so how hard could it be?" I got started. The UI is a bit ugly (I couldn't figure out how to add a switch, so the toggle for the curve is a float which is either 0.0 or 1.0) but the functionality is there.
I'm looking forward to hearing what could be improved and if this could be merged. Thank you for your consideration in any case.