Fix crash when broken symlinks exist in diffusion_models folder#628
Open
diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
Open
Fix crash when broken symlinks exist in diffusion_models folder#628diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
Conversation
Replace get_full_path_or_raise() with get_full_path() in INPUT_TYPES() to gracefully handle broken symlinks and missing files instead of crashing. Fixes FileNotFoundError when ComfyUI scans model folders containing broken symbolic links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
NunchakuFluxDiTLoadernode crashes during initialization when broken symbolic links exist in themodels/diffusion_models/folder, preventing ComfyUI from loading.Error:
Root Cause
In
nodes/models/flux.pyline 99,INPUT_TYPES()usesfolder_paths.get_full_path_or_raise()which throws an exception when encountering broken symlinks or missing files during the model list scan.Solution
Replace
get_full_path_or_raise()withget_full_path()and skipNoneresults (broken symlinks/missing files) instead of crashing.Changes
folder_paths.get_full_path_or_raise()→folder_paths.get_full_path()if safetensor_path is None: continueto skip invalid pathsTesting
Tested with broken symlinks in
models/diffusion_models/- node now loads without errors and properly skips invalid files.