fix: ensure contiguous tensors after slicing in QwenImage attention#696
Open
diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
Open
fix: ensure contiguous tensors after slicing in QwenImage attention#696diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
diodiogod wants to merge 1 commit intonunchaku-ai:mainfrom
Conversation
Addresses sporadic RuntimeError: "view size is not compatible with input tensor's size and stride". This error persists even after PR nunchaku-ai#673's fix to use .reshape() instead of .view() in the linear layer. The issue occurs when joint_hidden_states is sliced along sequence dimension, creating non-contiguous tensor views. While .reshape() should handle this, certain stride patterns still cause failures with PyTorch 2.8. Adding .contiguous() after slicing ensures tensors are copied to contiguous memory before being passed to nunchaku linear layers, preventing the crash. Related to nunchaku-ai#535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sporadic
RuntimeError: view size is not compatible with input tensor's size and stridethat persists even after PR nunchaku-ai/nunchaku#673.The Problem
Even with PR #673's fix (changing
.view()to.reshape()inlinear.py), users still experience sporadic crashes with the same error. The issue occurs when:joint_hidden_statesis sliced along the sequence dimension inqwenimage.py:319-320.reshape()theoretically handling non-contiguous tensors, certain stride patterns still cause failuresThis explains why:
The Fix
Add
.contiguous()immediately after slicing operations to ensure tensors are copied to contiguous memory before being passed to nunchaku linear layers.Environment
Questions for Maintainers
Why does
.reshape()inlinear.py:182still fail despite being designed to handle non-contiguous tensors? Is there:.reshape()can't handle?This PR is defensive programming that prevents the crash, but the root cause may need investigation.
Closes #535