Skip to content

fix: crash by illegal memory access#782

Merged
lmxyy merged 2 commits intonunchaku-ai:devfrom
devgdovg:fix/lowvram_crash
Jan 26, 2026
Merged

fix: crash by illegal memory access#782
lmxyy merged 2 commits intonunchaku-ai:devfrom
devgdovg:fix/lowvram_crash

Conversation

@devgdovg
Copy link
Contributor

@devgdovg devgdovg commented Jan 15, 2026

Motivation

Fix issue: #773

Modifications

add dummy comfy_cast_weights and weight fields for SVDQW4A4Linear module to make it compatible with low vram offloading in ComfyUI

Checklist

  • Code is formatted using Pre-Commit hooks (run pre-commit run --all-files).
  • Relevant unit tests are added in the tests/workflows directory following the guidance in the Contribution Guide.
  • Reference images are uploaded to PR comments and URLs are added to test_cases.json.
  • Additional test data (if needed) is registered in test_data/inputs.yaml.
  • Additional models (if needed) are registered in scripts/download_models.py and test_data/models.yaml.
  • Additional custom nodes (if needed) are added to .github/workflows/pr-test.yaml.
  • For reviewers: If you're only helping merge the main branch and haven't contributed code to this PR, please remove yourself as a co-author when merging.
  • Please feel free to join our Discord or WeChat to discuss your PR.

@devgdovg devgdovg changed the title fix crash by illegal memory access fix: crash by illegal memory access Jan 15, 2026
@devgdovg devgdovg marked this pull request as ready for review January 15, 2026 19:43
@lmxyy lmxyy closed this Jan 25, 2026
@lmxyy lmxyy reopened this Jan 25, 2026
Copy link
Collaborator

@lmxyy lmxyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed tests.

@lmxyy lmxyy merged commit b5c7feb into nunchaku-ai:dev Jan 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants