Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
When running z-image-turbo through nunchaku with a batch size > 1, the following occurred:
Otherwise, sampling single images is completely functional for me.
This problem started after commit c43921f
Environment:
Should fix #778; they use a batch size of 8.
Maybe related to #774; discusses the same assertion error.
Modifications
In the
RopeFuseAttentionHookduring a cache miss and a packedfreq_cismust be created,freq_cisis expanded to match the batch size of the input before being flattened with the sequence dimension before continuing on to be padded and packed:If we just use
expandby itself to match the batch size, it passes the assert, but the output images in the batch after the first image does not match the reference workflow, and is very low quality. I do not know how to avoid copying data here.A test case is added which was adapted from the regular z-image-turbo workflow, but with a batch size of 2 and a node for selecting the second image in the batch.
Checklist
pre-commit run --all-files).tests/workflowsdirectory following the guidance in the Contribution Guide.test_cases.json.test_data/inputs.yaml.scripts/download_models.pyandtest_data/models.yaml..github/workflows/pr-test.yaml.