Remove unexpected code in compose_lora to resolve bugs #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamwavecut
reviewed
Aug 11, 2025
Comment on lines
+191
to
+195
| """ | ||
| composed[k] = ( | ||
| v if previous_lora is None else torch.cat([previous_lora, v], dim=0 if "lora_A" in k else 1) | ||
| ) | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| composed[k] = ( | |
| v if previous_lora is None else torch.cat([previous_lora, v], dim=0 if "lora_A" in k else 1) | |
| ) | |
| """ |
No reason to comment it out; just remove it completely. It has no use anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #540
Motivation
Modifications
I think this is just a minor historical fix. To ensure compatibility with Flux-tool's LoRA, the original code had already extended the logic to support channel expansion. However, it seems the historical code was not removed, causing the updated logic to not actually take effect. Just comment it out to solve the problem.
Checklist
testsdirectory following the guidance inContribution Guide.examplesare updated if necessary.