feat: Enable deterministic LoRA activation reduction using fixed-point arithmetic #820
+49
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Floating-point atomic add operations (atomicAdd / red.add.f32) on GPUs are non-deterministic due to the unpredictable order of thread execution, causing slight variations in results. This non-deterministic behavior is problematic for scenarios requiring strict reproducibility, such as debugging, testing, and scientific computing.
This PR enables deterministic LoRA activation reduction by replacing floating-point reduction with fixed-point integer arithmetic, ensuring identical outputs for the same inputs across runs.
There also are some issues refer to this feature: #546 #229 #294
spooknik/nunchaku-chroma#6
Modifications