Skip to content

Introduce "non-runnable" runners and change engine to use them - #1732

Merged
CharliePoole merged 4 commits into
mainfrom
issue-1475
Jul 16, 2025
Merged

Introduce "non-runnable" runners and change engine to use them#1732
CharliePoole merged 4 commits into
mainfrom
issue-1475

Conversation

@CharliePoole

@CharliePoole CharliePoole commented Jul 12, 2025

Copy link
Copy Markdown
Member

Part of #1475

@CharliePoole

CharliePoole commented Jul 12, 2025

Copy link
Copy Markdown
Member Author

This was intended as a very targeted change but expanded a bit in the process. We are no longer using MultipleTestProcessRunner and have switched to using the base class, AggregatingTestRunner directly when there are multiple assemblies. That's because we no longer want to start a process for every assembly - or even for junk files - when they can be quickly disposed of by one of the special runners.

For simplicity, I left the code unchanged in AggregatingTestRunner. It still creates a separate thread per runner, whether it's a ProcessRunner or a NonRunnableTestAssemblyRunner.

Some tests may be non-runnable because a driver can't be found for them, so I had to leave a simple non-runnable driver in the agent core code.

@CharliePoole
CharliePoole requested review from a team and manfred-brands July 12, 2025 01:14
@CharliePoole
CharliePoole merged commit 7265a54 into main Jul 16, 2025
5 checks passed
@CharliePoole
CharliePoole deleted the issue-1475 branch July 16, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant