Clarify driver support for NUnit versions - #1857
Merged
Merged
Conversation
manfred-brands
approved these changes
Jul 27, 2026
manfred-brands
left a comment
manfred-brands
left a comment
Member
There was a problem hiding this comment.
One simplification possible, otherwise fine.
| { | ||
| return NUNIT_FRAMEWORK.Equals(reference.Name, StringComparison.OrdinalIgnoreCase) && reference.Version.Major >= 3; | ||
| int major = reference.Version.Major; | ||
| return NUNIT_FRAMEWORK.Equals(reference.Name, StringComparison.OrdinalIgnoreCase) && (major == 3 || major == 4); |
Member
There was a problem hiding this comment.
With the new pattern syntax you can say:
major is 3 or 4
in that case you don't even need the extra local variable.
Member
Author
There was a problem hiding this comment.
Nice! I still don't have that syntax on the tip of my fingers. :-(
CharliePoole
marked this pull request as ready for review
July 27, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #1856, fixing the version3 code so that it doesn't report support for NUnit versions past V4. We'll release this in conjunction with the framework V5 release.