Skip to content

Eliminate use of StopRun(true) - #1858

Draft
CharliePoole wants to merge 1 commit into
mainfrom
issue-1856
Draft

Eliminate use of StopRun(true)#1858
CharliePoole wants to merge 1 commit into
mainfrom
issue-1856

Conversation

@CharliePoole

Copy link
Copy Markdown
Member

Eliminates use of StopRun(bool) in the engine and agent core and fixes #1856.

StopRun(false) is replaced by RequestStop(), which is intended to make it clear that the test may not stop. The caller may only request it and the result depends on the test framework, possibly its version and the test code itself.

StopRun(true) is replace by ForcedStop(). If the test framework provides any facilities for such a stop, they are used. Otherwise, any non terminated processes are canceled by the engine.

The initial commit makes the necessary replacements but code to kill agent processes is not yet implemented.

@CharliePoole
CharliePoole marked this pull request as draft July 28, 2026 20:20
@CharliePoole

Copy link
Copy Markdown
Member Author

@manfred-brands
I'm keeping this as a draft until a few things are resolved...

  1. I'd like to see how you resolve Eliminate forced stop from the API nunit#5373 and accommodate the engine fix to whatever you do in the driver code.
  2. Deciding whether to Kill test processes from the engine in response to a forced stop and, if so, where to do it.
  3. Deciding whether to continue to fabricate TestSuite results in the engine after a forced stop or to expect clients (runners) to deal with it. In the PR, that code is currently removed using conditional compilation, so we can test the adapter with it.

It would be be useful if you'd take a look at the PR as it is now and let me know what you think.

@manfred-brands

Copy link
Copy Markdown
Member
  1. I'd like to see how you resolve Eliminate forced stop from the API nunit#5373 and accommodate the engine fix to whatever you do in the driver code.

I have raised nunit/nunit#5374

I left the signature for the FrameworkController the same (similar what you did earlier).
That way existing runners should still work (unless they set force to true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate forced stop from the API

2 participants