Eliminate use of StopRun(true) - #1858
Draft
CharliePoole wants to merge 1 commit into
Draft
Conversation
CharliePoole
marked this pull request as draft
July 28, 2026 20:20
Member
Author
|
@manfred-brands
It would be be useful if you'd take a look at the PR as it is now and let me know what you think. |
Member
I have raised nunit/nunit#5374 I left the signature for the FrameworkController the same (similar what you did earlier). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates use of
StopRun(bool)in the engine and agent core and fixes #1856.StopRun(false)is replaced byRequestStop(), which is intended to make it clear that the test may not stop. The caller may only request it and the result depends on the test framework, possibly its version and the test code itself.StopRun(true)is replace byForcedStop(). If the test framework provides any facilities for such a stop, they are used. Otherwise, any non terminated processes are canceled by the engine.The initial commit makes the necessary replacements but code to kill agent processes is not yet implemented.