🚸 UX: Use anchor tags in article-meta/basic.html

[servedsmart]

• This removes an inline event handler
• This also adds an aria-label

Purpose

Using javascript instead of just using <a> tag is bad practice regarding accessibility and automated processing of web pages. Even the browser doesn't show a hint if hovering badges when using the old implementation. This in my opinion is a good way to replace inline event handlers in that code.

Notes

Previously, this was part of #2231 and #2218, but after some thinking, I just split up the PR.

Warning

⚠️ This currently isn't compatible with #2249 and #2268. Please notify me to make the necessary changes.

[netlify]

✅ Deploy Preview for snazzy-dango-efb2ec ready!

Name	Link
🔨 Latest commit	5d6b034
🔍 Latest deploy log	https://app.netlify.com/projects/snazzy-dango-efb2ec/deploys/685328ac006de30008002d03
😎 Deploy Preview	https://deploy-preview-2252--snazzy-dango-efb2ec.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[nunocoracao]

@servedsmart conflicts here - can you have a look?

[nunocoracao]

@servedsmart conflicts again - sorry

[servedsmart]

@servedsmart conflicts again - sorry

Thank you for notifying me and that's not a problem.

ℹ️ This has been tested on 2c71bda and is working just fine.

[ZhenShuo2021]

Hi @servedsmart

Hope you’re doing well!

I noticed that after @nunocoracao merged this commit, it seems to have caused some issues with the article links:

1. The underline below the title is missing
2. The article shortcode is broken

To double-check, I tried reverting the following commits:
git revert b73c64f4f53bbf74ad1b4f1d332b772445bdeba6
git revert 5e8561d83b1ffddf8401ee1c38997156303a5c0f
After reverting, everything appeared to work properly again, which makes me think these changes might be the cause.

Whenever you have a chance, could you please take a look? Thanks a lot!

[servedsmart]

Hi @servedsmart

Hope you’re doing well!

I noticed that after @nunocoracao merged this commit, it seems to have caused some issues with the article links:

1. The underline below the title is missing

2. The `article` shortcode is broken

To double-check, I tried reverting the following commits: git revert b73c64f4f53bbf74ad1b4f1d332b772445bdeba6 git revert 5e8561d83b1ffddf8401ee1c38997156303a5c0f After reverting, everything appeared to work properly again, which makes me think these changes might be the cause.

Whenever you have a chance, could you please take a look? Thanks a lot!

Regarding 2.. This will take some work, I'm not sure how that has happened. See: https://deploy-preview-2252--snazzy-dango-efb2ec.netlify.app/docs/shortcodes/ There it works, that was my original deploy preview. It probably messed up because of other changes, I will resolve this ASAP.

Regarding 1. It seems like I didn't notice that, thank you very much for telling me. This will also be fixed.

[servedsmart]

@ZhenShuo2021 I fixed all mentioned issues in #2351.

I did some testing and currently don't have a reason to think that this introduced additional bugs, I hope that this hotfix is working correctly now.

[ZhenShuo2021]

@servedsmart thank you very much for your quick fix!