Skip to content

♻️ Refactor: Use universal json for repo shortcodes and move styles out of line#2269

Merged
nunocoracao merged 3 commits intonunocoracao:devfrom
servedsmart:use-data-repo-colors-and-move-out-of-line
Jul 10, 2025
Merged

♻️ Refactor: Use universal json for repo shortcodes and move styles out of line#2269
nunocoracao merged 3 commits intonunocoracao:devfrom
servedsmart:use-data-repo-colors-and-move-out-of-line

Conversation

@servedsmart
Copy link
Copy Markdown
Contributor

This has been tested for 10 minutes in different scenarios and is working just like it did before.

Purpose

  • Having 4 json files with different names but the same content isn't a good idea.
  • Using classes here is quite straight-forward and reduces the amount of inline styles if people use any of the relevant repo shortcodes. This can reduce the size of a CSP and improve maintainability by not having the same inline script logic in 4 different files.

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 22, 2025

Deploy Preview for snazzy-dango-efb2ec ready!

Name Link
🔨 Latest commit 13f8177
🔍 Latest deploy log https://app.netlify.com/projects/snazzy-dango-efb2ec/deploys/68588e30ba54f30008351698
😎 Deploy Preview https://deploy-preview-2269--snazzy-dango-efb2ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@servedsmart servedsmart changed the title ♻️ Refactor Use universal json and move styles out of line ♻️ Refactor: Use universal json and move styles out of line Jun 22, 2025
@servedsmart servedsmart force-pushed the use-data-repo-colors-and-move-out-of-line branch from a30083b to 1c0ad61 Compare June 22, 2025 03:09
@servedsmart servedsmart marked this pull request as draft June 22, 2025 03:24
@servedsmart

This comment was marked as resolved.

@servedsmart servedsmart marked this pull request as ready for review June 22, 2025 20:24
@servedsmart servedsmart changed the title ♻️ Refactor: Use universal json and move styles out of line ♻️ Refactor: Use universal json for repo shortcodes and move styles out of line Jun 22, 2025
@servedsmart servedsmart changed the base branch from main to dev June 27, 2025 17:16
@servedsmart servedsmart force-pushed the use-data-repo-colors-and-move-out-of-line branch from 13f8177 to ef8d1f8 Compare June 27, 2025 17:20
@nunocoracao
Copy link
Copy Markdown
Owner

@servedsmart conflicts - can you fix?

@servedsmart servedsmart force-pushed the use-data-repo-colors-and-move-out-of-line branch 2 times, most recently from 4cc53b0 to 560a88d Compare July 9, 2025 16:44
@servedsmart
Copy link
Copy Markdown
Contributor Author

@servedsmart conflicts - can you fix?

All conflicts are resolved now.

@servedsmart servedsmart force-pushed the use-data-repo-colors-and-move-out-of-line branch from 560a88d to 25977d8 Compare July 9, 2025 17:19
@servedsmart
Copy link
Copy Markdown
Contributor Author

ℹ️ Tested working on latest commit 8d94088 to dev branch after rebase.

@nunocoracao nunocoracao merged commit 6d94d1d into nunocoracao:dev Jul 10, 2025
1 check passed
@servedsmart servedsmart deleted the use-data-repo-colors-and-move-out-of-line branch July 10, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants