✨ Add leaflet shortcode that adds map without storing cookies#2277
Closed
servedsmart wants to merge 7 commits intonunocoracao:mainfrom
Closed
✨ Add leaflet shortcode that adds map without storing cookies#2277servedsmart wants to merge 7 commits intonunocoracao:mainfrom
servedsmart wants to merge 7 commits intonunocoracao:mainfrom
Conversation
✅ Deploy Preview for snazzy-dango-efb2ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
There is currently an issue with z-indexes that are being assigned by leaflet not being compatible with the theme layout, therefore this needs some more work and testing. |
Contributor
Author
|
I will switch this to OpenLayers for myself. I might submit a PR for that later. It isn't as straight forward as this, therefore it might be hard to maintain here. If someone would want that feature though, I will definetly add a PR here. I have got it working quite well at the moment but my current implementation is still being tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been tested for functionality and every shortcode parameter has been tested separately.
Purpose
This does not store any cookies/localstorage etc. and therefore should be easy to implement even for EU countries.
As far as I know, using the iframe from OpenStreetMap or UMAP is not compatibly with a lot of security headers and requires storing a cookie. Because of the cookie, it requires
Cross-Origin-Embedder-Policy: unsafe-noneaccording to my testing.This is compatible with the following HTTP security headers (only relevant ones are included):
Example
This is the documentation with an example of how the map would look.