[Ek Chin Hui] iP #452
[Ek Chin Hui] iP #452
Conversation
# Conflicts: # src/main/java/Duke.java
| * Getter for isDone. | ||
| * @return boolean of the status of the task. | ||
| */ | ||
| public boolean getIsDone() { |
There was a problem hiding this comment.
Not sure whether you really need a getter when you can make the isDone boolean public
FH-30
left a comment
FH-30
left a comment
There was a problem hiding this comment.
Overall good quality code, just a few nits to fix.
|
|
||
| /** | ||
| * Constructor for Deadline, initialises description | ||
| * in the base class and also the dueDate. |
There was a problem hiding this comment.
Perhaps an empty line between description and parameter section of javadoc?
|
|
||
| /** | ||
| * Constructor for Duke class, initialises objects | ||
| * for Storage, TaskList and Ui. |
There was a problem hiding this comment.
Perhaps an empty line between description and parameter section of javadoc? I noticed the same issue in several other places too.
| /** | ||
| * Base class for custom exceptions specific to Duke. | ||
| */ | ||
| public class DukeException extends Exception{ |
There was a problem hiding this comment.
Should there be spacing after "Exception" and before the curly brace?
| String month = dueDate.getMonth().getDisplayName(TextStyle.SHORT, Locale.forLanguageTag("en")); | ||
| int day = dueDate.getDayOfMonth(); | ||
| int year = dueDate.getYear(); | ||
| String timeDisplay = String.format("%d %s %d", day, month, year); | ||
| return "[D]" + super.toString() + String.format(" (by: %s)", timeDisplay); |
There was a problem hiding this comment.
Perhaps it might be good to separate logical units in a block of code with blank lines?
src/main/java/duke/Event.java
Outdated
| String month = time.getMonth().getDisplayName(TextStyle.SHORT, Locale.forLanguageTag("en")); | ||
| int day = time.getDayOfMonth(); | ||
| int year = time.getYear(); | ||
| String timeDisplay = String.format("%d %s %d", day, month, year); | ||
| return "[E]" + super.toString() + String.format(" (at: %s)", timeDisplay); |
There was a problem hiding this comment.
I think it might be good to separate logical units in a block of code with blank lines. I noticed the same issue in several other places too.
src/main/java/duke/Parser.java
Outdated
| ui.printMessage("Added: " + task | ||
| + String.format("\nNow you have %d tasks in the list", taskList.getTaskList().size())); |
There was a problem hiding this comment.
I like how you break before an operator and after a comma, I have also noticed this in other sections of your code! 👍
Add assert statements
Refactor storage class
3 participants
No description provided.