[Cao] iP #466

Ringo1225 · 2020-08-30T14:42:00Z

No description provided.

…evel-3

Allowed task with deadlines and date/time. Achieved level-4

Lingy12

There is no violation of the coding standard. You follow the naming layout and comment. But could you try to pack the statement, especially for the output (eg. pack printing output format into a function, so that you can just call that function to print output, instead of using multiple lines to print the lines etc). Also, perhaps adding some comment in each logical block and some Javadoc can provide better documentation.

yuanxing-z · 2020-08-31T14:20:05Z

src/main/java/Deadline.java

+package main.java;
+
+public class Deadline extends Task {
+    protected String deadline;


Suggest using private keyword instead of protected.

yuanxing-z · 2020-08-31T14:21:57Z

src/main/java/Duke.java

                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);
+        System.out.println("    ____________________________________________________________");
+        System.out.println("     Hello! I'm Duke\n     What can I do for you?");


different parts of the code can be grouped together as a method, make it easier for abstraction.

yuanxing-z · 2020-08-31T14:22:21Z

src/main/java/Event.java

+package main.java;
+
+public class Event extends Task {
+    protected String time;


same suggestion as deadline

yuanxing-z

Some suggestions are made as single comment in each file, overall the code quality is good. Feel free to reply if you have any questions regarding the comments.

simplified the main class

updated testcases

junhui-phoon · 2020-09-06T19:54:57Z

src/main/java/CommandHandler.java

+        while (true) {
+            String command = sc.next();
+            switch (command) {
+                case "bye":


There's no indention for the case statements. It should be 'aligned' with the switch statement.

junhui-phoon · 2020-09-06T20:25:54Z

src/main/java/CommandHandler.java

+                    try {
+                        handleDone();
+                    } catch (DukeException e) {
+                        System.out.println("    ____________________________________________________________");


Maybe you could abstract out this border line as a variable, then call it whenever you need it. Makes the code tidy.

junhui-phoon · 2020-09-06T20:29:00Z

src/main/java/CommandHandler.java

+    public void handleDone() throws DukeException {
+        String doneCommand = sc.nextLine();
+        int index = 0;
+        if (doneCommand.isEmpty()) {
+            throw new DukeException("\u2639 OOPS!!! I need to know the index of the task to be done!");
+        }
+        try {
+            index = Integer.parseInt(doneCommand.stripLeading());
+        } catch (NumberFormatException e) {
+            System.out.println("    ____________________________________________________________");
+            System.out.println("     \u2639 Please enter a valid integer!!");
+            System.out.println("    ____________________________________________________________\n");
+            return;
+        }
+        if (index > taskList.size()) {
+            throw new DukeException("\u2639 Your number is too large!!");
+        }
+        Task currentTask = taskList.get(index - 1);
+        currentTask.markAsDone();
+        System.out.println("    ____________________________________________________________");
+        System.out.println("     Nice! I've marked this task as done:");
+        System.out.print("     ");
+        currentTask.printDescription();
+        System.out.println("    ____________________________________________________________\n");
+    }


Perhaps you could add appropriate line breaks to enhance readability

junhui-phoon · 2020-09-06T20:29:48Z

src/main/java/CommandHandler.java

+        String deleteCommand = sc.nextLine();
+        int index = 0;
+        if (deleteCommand.isEmpty()) {
+            throw new DukeException("\u2639 OOPS!!! I need to know the index of the task to be deleted!");
+        }
+        try {
+            index = Integer.parseInt(deleteCommand.stripLeading());
+        } catch (NumberFormatException e) {
+            System.out.println("    ____________________________________________________________");
+            System.out.println("     \u2639 Please enter a valid integer!!");
+            System.out.println("    ____________________________________________________________\n");
+            return;
+        }
+        if (index > taskList.size()) {
+            throw new DukeException("\u2639 Your number is too large!!");
+        }
+        Task currentTask = taskList.get(index - 1);
+        taskList.remove(index - 1);
+        System.out.println("    ____________________________________________________________");
+        System.out.println("     Noted! I've removed this task:");
+        System.out.print("     ");
+        currentTask.printDescription();
+        System.out.println("     Now you have " + taskList.size() + " tasks in the list.");
+        System.out.println("    ____________________________________________________________\n");


Same comment as above. Line breaks for readability.

… from the file.

* branch-Level-7: solved the bug when the command.txt does not exist. Saved the list of tasks in a txt. file. Every time will load the data from the file.

* branch-Level-8: Stored Deadline data as java.time.LocalDate # Conflicts: # src/main/java/CommandHandler.java # src/main/java/Deadline.java

* branch-GUI: Add FXML Restructure project Finish GUI feature Improve GUI Add some GUI feature Edit build.gradle Revise project structure

Add assertions

* 'master' of https://github.com/Ringo1225/ip: Add assertions

* master: Add assertions

* branch-A-CodeQuality: Improve code quality Add assertions

Improve code quality

* 'master' of https://github.com/Ringo1225/ip: Improve code quality

* master:

Add feature: FixedDurationTasks

* 'master' of https://github.com/Ringo1225/ip: Add feature: FixedDurationTasks

* 'master' of https://github.com/Ringo1225/ip: Set theme jekyll-theme-minimal

* 'master' of https://github.com/Ringo1225/ip: Set theme jekyll-theme-midnight

Ringo1225 added 10 commits August 20, 2020 22:11

Added features for Greet, Echo and Exit

a0828cb

Added features of Level-2, Add and List

2a955ed

Added done feature, but not achieved

2960cdb

Add package main.java

e6f5a1b

Adjusted the robot's responding style

d619ffa

Added a Task class, but did not merge it with the main class Duke.java

7a01956

added printDescription() method to Task class

23ff51e

Merged Task.java class with Duke.java class, completed features for l…

aaf0db0

…evel-3

Added classes Todo, Deadline, Event.

b989315

Allowed task with deadlines and date/time. Achieved level-4

Added feature for Automated Text UI Testing

46c1cf5

Lingy12 reviewed Aug 31, 2020

View reviewed changes

yuanxing-z reviewed Aug 31, 2020

View reviewed changes

src/main/java/Event.java Outdated

package main.java;

public class Event extends Task {

protected String time;

Copy link

yuanxing-z Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same suggestion as deadline

yuanxing-z reviewed Aug 31, 2020

View reviewed changes

Ringo1225 added 6 commits September 2, 2020 23:44

Added feature for Exception handling

bf02861

simplified the main class

Handled exceptions for deadline

9ed888d

updated testcases

updated exceptions handling for event

4630050

Finished delete function

eccd4bd

Handled exception for Done

518a798

Updated exception handling for delete operation

3d92ca2

junhui-phoon reviewed Sep 6, 2020

View reviewed changes

Ringo1225 added 5 commits September 7, 2020 22:57

Saved the list of tasks in a txt. file. Every time will load the data…

488eaec

… from the file.

solved the bug when the command.txt does not exist.

74ae682

Stored Deadline data as java.time.LocalDate

fc5812c

Merge branch 'branch-Level-7'

fd6a9b3

* branch-Level-7: solved the bug when the command.txt does not exist. Saved the list of tasks in a txt. file. Every time will load the data from the file.

Merge branch 'branch-Level-8'

9528c06

* branch-Level-8: Stored Deadline data as java.time.LocalDate # Conflicts: # src/main/java/CommandHandler.java # src/main/java/Deadline.java

Ringo1225 and others added 30 commits September 17, 2020 15:20

Finish GUI feature

6ed168a

Restructure project

6703d18

Add FXML

4867fea

Merge branch 'branch-GUI'

600c0da

* branch-GUI: Add FXML Restructure project Finish GUI feature Improve GUI Add some GUI feature Edit build.gradle Revise project structure

Try to create a jar file

31edbef

Add assertions

c24a998

Improve code quality

7dd194a

Add feature: FixedDurationTasks

a99084c

Merge pull request #3 from Ringo1225/branch-A-Assertions

3f9875b

Add assertions

Merge branch 'master' of https://github.com/Ringo1225/ip

2b5a07c

* 'master' of https://github.com/Ringo1225/ip: Add assertions

Merge branch 'master' into branch-A-CodeQuality

4e15055

* master: Add assertions

Merge branch 'branch-A-CodeQuality' into branch-B-FixedDurationTasks

ce96300

* branch-A-CodeQuality: Improve code quality Add assertions

Merge pull request #1 from Ringo1225/branch-A-CodeQuality

19baa19

Improve code quality

Merge branch 'master' of https://github.com/Ringo1225/ip

25b7998

* 'master' of https://github.com/Ringo1225/ip: Improve code quality

Merge branch 'master' into branch-B-FixedDurationTasks

1e4cdf2

* master:

Merge pull request #2 from Ringo1225/branch-B-FixedDurationTasks

1046b5e

Add feature: FixedDurationTasks

Merge branch 'master' of https://github.com/Ringo1225/ip

19b36fb

* 'master' of https://github.com/Ringo1225/ip: Add feature: FixedDurationTasks

Add reuse acknowlegement

cf73057

Add Ui.png

4037756

Update user guide

1655726

Set theme jekyll-theme-minimal

4b7aeb1

Revise user guide

74aa3da

Merge branch 'master' of https://github.com/Ringo1225/ip

cbb962b

* 'master' of https://github.com/Ringo1225/ip: Set theme jekyll-theme-minimal

Revise User Guide

3457ff4

Revise User Guide

8e00007

Set theme jekyll-theme-midnight

9a57b7a

revise build.gradle, generate a jar file

5513e6d

Merge branch 'master' of https://github.com/Ringo1225/ip

bd54f7a

* 'master' of https://github.com/Ringo1225/ip: Set theme jekyll-theme-midnight

update jar file version

777b9e0

Set theme jekyll-theme-minimal

1615411

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Cao] iP #466

[Cao] iP #466

Uh oh!

Ringo1225 commented Aug 30, 2020

Uh oh!

Lingy12 left a comment

Uh oh!

yuanxing-z Aug 31, 2020

Uh oh!

yuanxing-z Aug 31, 2020

Uh oh!

yuanxing-z Aug 31, 2020

Uh oh!

yuanxing-z left a comment

Uh oh!

junhui-phoon Sep 6, 2020

Uh oh!

junhui-phoon Sep 6, 2020

Uh oh!

junhui-phoon Sep 6, 2020

Uh oh!

junhui-phoon Sep 6, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Cao] iP #466

Are you sure you want to change the base?

[Cao] iP #466

Uh oh!

Conversation

Ringo1225 commented Aug 30, 2020

Uh oh!

Lingy12 left a comment

Choose a reason for hiding this comment

Uh oh!

yuanxing-z Aug 31, 2020

Choose a reason for hiding this comment

Uh oh!

yuanxing-z Aug 31, 2020

Choose a reason for hiding this comment

Uh oh!

yuanxing-z Aug 31, 2020

Choose a reason for hiding this comment

Uh oh!

yuanxing-z left a comment

Choose a reason for hiding this comment

Uh oh!

junhui-phoon Sep 6, 2020

Choose a reason for hiding this comment

Uh oh!

junhui-phoon Sep 6, 2020

Choose a reason for hiding this comment

Uh oh!

junhui-phoon Sep 6, 2020

Choose a reason for hiding this comment

Uh oh!

junhui-phoon Sep 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

junhui-phoon Sep 6, 2020 •

edited

Loading