[Chanell Ng] iP#244
Conversation
| }else { | ||
| createBot("data/duke.txt", bot); | ||
| } | ||
| }catch (IOException e){ |
|
Concise code, only importing necessary libraries. Good abstraction of printing functions like echo. Overall structure of code is good, with a few formatting errors here and there. |
weixue123
left a comment
weixue123
left a comment
There was a problem hiding this comment.
Hello, I find that there were parts of your code that made good sense and were very readable. Great job!
| Ui ui = new Ui(bot); | ||
|
|
||
| while (!(input.equals("bye"))) { | ||
| if (input.equals("list")) { |
There was a problem hiding this comment.
Perhaps the code can be more readable if the IF/ELSE statements are written in a way that is less nested?
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
I feel that the use of line breaks can be more consistent! For example, whether or not to include an empty line at the EOF, or how many of such empty lines to put, etc.
| package ip.src.main.java; | ||
| import java.util.Scanner; | ||
|
|
||
| public class Level_1 { |
There was a problem hiding this comment.
Maybe consider deleting dead code? So that your codebase can be simpler and easier to understand.
Added assert statments
Made changes to improve code quality
4 participants
No description provided.