[Glenn Lee] iP#246
Open
glennljs wants to merge 59 commits into
Open
Conversation
added 24 commits
January 31, 2021 20:46
Add Level 7 Features.
Added Level-8 Features.
zhoube
reviewed
Feb 2, 2021
zhoube
reviewed
Feb 2, 2021
zhoube
left a comment
zhoube
left a comment
There was a problem hiding this comment.
Very well done! I believe you have adhered to almost all of the Java Coding Standards!
yienyoong
reviewed
Feb 3, 2021
yienyoong
left a comment
yienyoong
left a comment
There was a problem hiding this comment.
Your code is easy to read and largely follows coding standards. Nice work!
| /** | ||
| * | ||
| */ | ||
| private static final long serialVersionUID = 4447981462872622989L; |
There was a problem hiding this comment.
Perhaps this should be 'SERIAL_VERSION_UID' as it is a constant?
Author
There was a problem hiding this comment.
I also thought so but apparently this is some optional requirement by java and is meant to be spelled like this? I'm not too sure because my IDE (vscode) added it in automatically.
Improve Code Quality
Branch a assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.