[Ryan Jee] iP#268
Open
rjeez wants to merge 193 commits into
Open
Conversation
danielonges
reviewed
Feb 6, 2021
danielonges
left a comment
danielonges
left a comment
There was a problem hiding this comment.
Generally code is quite well written! However, might want to be careful in leaving spaces where necessary in order not to violate coding standards. Other than that, LGTM!
|
|
||
|
|
||
| public Duke(String filePath){ | ||
| ui = new Ui(); |
There was a problem hiding this comment.
Might want to consider removing extra space(s) between new Ui()
| Command command = parser.parse(input); | ||
| String reply = command.execute(ui,taskList, storage); | ||
| storage.writeFile(); | ||
| assert(reply!=null); |
| DukeList dukeList = new DukeList(); | ||
| StringBufferTasks = new StringBuffer(); | ||
| try{ | ||
| BufferedReader reader = new BufferedReader(new InputStreamReader(new DataInputStream(new FileInputStream(this.filename)))); |
| Path filePath = Path(current,filename); | ||
| boolean directoryExist = Files.exists(direcPath); | ||
| boolean fileExist = Files.exists(filePath); | ||
| try{ |
There was a problem hiding this comment.
Might want to include spacing in between try {
|
|
||
| public String showTaskAdded(String task, List<Task> taskList){ | ||
| assert(task != null && taskList != null); | ||
| return String.format( "Added the following task : \n" + "%s\n" + "You now have %d tasks in your list.\n", task, taskList.size()); |
|
|
||
| public Storage (String filename){ | ||
| this.filename = new File(filename); | ||
| accessTaskListInFileSystem(getCurrentDirectory()); |
| return " [" + type + "] " + " [" + getStatusIcon() + "] " + getname(); | ||
| } | ||
| else{ | ||
| return " [" + type + "] " + " [" + getStatusIcon() + "] " + getname() + " " + dateTime.format(DateTimeFormatter.ofPattern("yyyy-MM-dd kkmm")); |
Add CBye class for command bye
Add CDeadline class for command deadline
Add CDelete class for command delete
Add CDone class for command done
Add CEvent class for command event
Add CList class for command list
Added javadoc
Added javadoc
update package
Added javadoc
Updated package
Added javadoc
Added javadoc
Added javadoc
Added javadoc
Added javadoc
Added javadoc
Added javadoc
Added javadoc
Add bot.png
Add user picture
Updated expected output
Update test input
Update name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.