[Jared Lim] iP#276
Conversation
Added ArrayList to store input.
|
|
||
| /** | ||
| * Main class to take in user input. | ||
| * @param args Filler |
There was a problem hiding this comment.
Perhaps a more meaningful name for @param could be possibly replaced here
| } | ||
|
|
||
| /** | ||
| * Overriden constructor to account for deadline and events that have timestamps. |
There was a problem hiding this comment.
Not too sure if "Overriden" is the appropriate term here. I think "Overloaded constructor" may be more appropriate.
| } | ||
|
|
||
| /** | ||
| * Enumerates all tasks in the lis using 1-based indexing. |
| * @param description Description of method | ||
| * @param eventDate Boolean flag indicating whether task is done | ||
| */ | ||
| public Task(String description, String eventDate) { |
There was a problem hiding this comment.
Might be a good idea to add "@OverRide" tag if this method is truly overriden
wei-yutong
left a comment
wei-yutong
left a comment
There was a problem hiding this comment.
your code is generally very clean and easy to read! i liked how your method names were clear and how you separated long lines accurately :)
| /** | ||
| * Driver class that takes in input and performs certain functions based on input. | ||
| */ | ||
| public class Duke { |
There was a problem hiding this comment.
this class is rather long, perhaps you could consider abstracting the methods out?
| } else if (command.equals("list")) { | ||
| enumerateTasks(); | ||
| } else if (command.startsWith("done")) { | ||
| String[] delString = command.split("\\s+"); |
There was a problem hiding this comment.
delString is not a very intuitive variable name, maybe you could make it more specific?
| } | ||
|
|
||
| /** | ||
| * Overriden constructor to account for deadline and events that have timestamps. |
There was a problem hiding this comment.
i think the term you meant to use might be "overloaded" instead
| low, | ||
| average, | ||
| high |
There was a problem hiding this comment.
I think that constants in enum should be in all uppercase, eg "LOW", "AVERAGE" and "HIGH"
| } | ||
|
|
||
| /** | ||
| * Overriden method to mark a task as done. |
There was a problem hiding this comment.
Did you mean "Overloaded" here as well? I've noticed it in a few other places. Otherwise, as the other reviewer mentioned, overridden methods should tagged with "@OverRide"
Included the gradle wrapper and the associated dependencies for the Junit test. Added two JUnit Test: One to test the loading of the stored text file, the other to test marking as done utility. Both under src/test/java.
Applied changes to all other dependent classes as well.
…checks for non empty objects, and list to avoid unchecked null pointers which can crash the program.
…s as much as possible by abstracting it away into the Task classes.
…ption to specify type of search: partial case sensitive, partial non- case sensitive, full exact match.
GUI echoes user commands, returns output by bot.
…methods which are quite clear.
…method body. Prevented as much as possible the use of magic strings when it comes to important kinds of data. Avoided direct usage of list indexing in Duke method by abstracting to the TaskList method.
…nsistencies for specific inputs like missing spaces.
This reverts commit 518584e.
3 participants
No description provided.