[Saha9616] iP #371
Open
[Saha9616] iP #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeyi45
reviewed
Feb 3, 2023
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,24 @@ | |||
| public class Deadline extends Task{ | |||
There was a problem hiding this comment.
Your files are missing package declarations
src/main/java/Duke.java
Outdated
| @@ -1,10 +1,93 @@ | |||
| import java.util.*; | |||
src/main/java/Event.java
Outdated
|
|
||
| @Override | ||
| public String toString() { | ||
| if(super.status == true) { |
There was a problem hiding this comment.
There should be a space between if and (
src/main/java/Duke.java
Outdated
|
|
||
| lst.add(new Todo(str)); | ||
| } | ||
| else if((str.split(" ", 2)[0]).equals("deadline")) { |
src/main/java/Duke.java
Outdated
| if((str.split(" ", 2).length == 1)) { | ||
| throw new NoDescriptionException(); | ||
| } | ||
| else if((str.split(" ", 2)[0]).equals("todo")) { |
There was a problem hiding this comment.
Maybe you should consider using equalsIgnoreCase instead
anthonynmh
reviewed
Feb 4, 2023
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,24 @@ | |||
| public class Deadline extends Task{ | |||
src/main/java/Event.java
Outdated
Comment on lines
7
to
13
| String[] mainSplit = super.task_name.split(" ", 2); //original : "event project meeting /from Mon 2pm /to 4pm" | ||
| String name = mainSplit[1]; // gives "project meeting /from Mon 2pm /to 4pm" | ||
| String[] StrList1 = name.split(" /from ", 2); //gives ["project meeting","Mon 2pm /to 4pm"] | ||
| String nameMain = StrList1[0]; //gives "project meeting" | ||
| String[] StrList2 = StrList1[1].split(" /to ", 2); //gives ["Mon 2pm", "to 4pm"] | ||
| String frm = StrList2[0]; //gives "Mon 2pm" | ||
| String to = StrList2[1]; //gives "to 4pm" |
There was a problem hiding this comment.
Perhaps proper naming of variables can help to reduce the number of comments. Maybe consider frm to be renamed to startingTime and to to endingTime.
Branch a code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THANOS
Thanos frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: