[jonyeokj] iP by jonyeokj · Pull Request #518 · nus-cs2103-AY2324S1/ip

jonyeokj · 2023-09-02T09:57:12Z

Martin Bot

Martin learned chess so that he could play with his young kids. He still beats them most of the time. (source)

Once a chess bot, now a chatbot!

Martin is:

🖋 Text-based
🎓 Easy to pick up
🚄 ~~FAST~~ Super FAST to use

All you need to do is,

download martin here.
double-click it.
add your tasks.
let it manage your tasks for you!

🎉 It's Absolutely Free! 🎉

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you're a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…lid task numbers and already marked/unmarked tasks

…ction in main

Gavino3o

Overall, the PR LGTM 👍. Some small changes can be considered but good progress has been made! Cheers and have a good day.

Gavino3o · 2023-09-04T14:59:19Z

+            throw new InvalidCommandException("☹ OOPS!!! I'm sorry, but I don't know what that means :-(");
+        }
+
+        String[] parts = input.split(" ", 2);


Good use of nouns and paid special attention to using plural forms when needed. Good job!

Gavino3o · 2023-09-04T15:00:08Z

+                return new DateCommand(input, tasks);
+            case "find":
+                return new FindCommand(input, tasks);
+            default:


Default case included as per coding standard. 👍

Gavino3o · 2023-09-04T15:01:09Z

+
+    @Override
+    public String toString() {
+        return "[E][" + (isDone ? "X" : " ") + "] " + description + " (from: " + from + " to: " + to + ")";


Consider using String.format here, it makes the string more readable and easier to edit if required in the future.

Gavino3o · 2023-09-04T15:04:25Z

+
+        String type = parts[0];
+
+        switch (type) {


If it's only two conditions, consider using if else instead. But I can see the potential of including todos, events and more subtypes of Tasks in the future.

Gavino3o · 2023-09-04T15:08:03Z

@@ -0,0 +1,37 @@
+package martin;
+import java.util.Scanner;
+


Consider adding JavaDocs for classes for a short description of what the class encapsulates or can do.

wui-hong

Overall, LGTM. Only minor suggestions but they are nitpicks!

wui-hong · 2023-09-06T13:21:03Z

+        isDone = true;
+    }
+
+    public void unmarkAsDone() {


Would it be more appropriate to rename the function to markAsUndone?

wui-hong · 2023-09-06T13:24:33Z

+    }
+
+    public void showLine() {
+        System.out.println("    ____________________________________________________________");


Perhaps adding the Line string as a constant would make your code more readable and reusable

wui-hong · 2023-09-06T13:25:49Z

+                Files.createFile(path);
+            }
+            Files.write(path, lines, StandardOpenOption.TRUNCATE_EXISTING);
+        } catch (IOException e) {


Good use of error handling throughout the code

wui-hong · 2023-09-06T13:26:34Z

+        }
+
+        ui.showLine();
+        System.out.println("     Tasks on " + date.format(DateTimeFormatter.ofPattern("M d yyyy")) + ":");


Might be neater to split out the date formatting section onto a new line

erohsikivar

Overall LGTM. Just some minor things can be changed.

erohsikivar · 2023-09-10T15:06:34Z

+ *
+ * @param message Error message to be printed out.
+ */
+public class InvalidCommandException extends MartinException {


I feel maybe don't so many classes for each exceptions since all your class methods are implementing same line of code super(message).

erohsikivar · 2023-09-10T15:07:51Z

@@ -0,0 +1,63 @@
+package martin.gui;


Good to see that you have separate GUI package.

- Added assertions to handle null values for input in the MainWindow class. - Ensured null responses are appropriately handled in the Martin class. - Introduced error handling for scenarios where the input is empty.

Implement assertions for null values

Refactored code in the DateCommand class to minimize arrowhead style code. Also added javadoc headers for all the command messages briefly explaining what theydo, and cleaned up the headers for their respective execute() commands.

Implement A-CodeQuality

This commit introduces the snooze command for the task management app. Users can now snooze their tasks, delaying them by a specified amount of times in minutes. Additionally, events now support the toFileFormat method. Javadoc headers have also been added to all command class constructors.

Implement Snooze and enhance Event format

Implement SortCommand to enable task sorting functionality. Extend the fromFileFormat method in Task to handle Event tasks.

Implement Sort Command and support for parsing Events

jonyeokj added 18 commits August 24, 2023 23:03

Changed Duke to Martin

39c0d76

Added isDone Functionality and Task.java

4d307d8

Added Tracking for Tasks: Todos, Events, Deadlines

5a7a311

Abstraction of adding Task functions

37a5502

Edited Duke to Martin in runtest files

7f32576

Added Exceptions for empty tasks descriptions, invalid commands, inva…

1228c38

…lid task numbers and already marked/unmarked tasks

Added Delete Function for tasks

a46f9a8

Added saving functionality, tasks are saved and remembered

b47fcbf

Removed wildcard import and added header messages to functions

380082a

Added Date and Time formatting to Deadline class, also Added date fun…

3a1360f

…ction in main

Created Parser, Storage, UI and TaskList classes for better OOP

0930fb3

Added Command interface and classes and organized files into packages

002306a

Added Gradle Support

d6550fc

Added DeleteCommandTest and TodoCommandTest files

2a1c9a5

Implemented the Fat Jar

67dc221

Add JavaDoc comments to the code

2b2ea68

Added Find Command

e4b277c

Added Header comments for Exception classes

6b39994

Gavino3o reviewed Sep 4, 2023

View reviewed changes

wui-hong reviewed Sep 6, 2023

View reviewed changes

Changed Martin Bot from CLI to a GUI interface

097541b

erohsikivar reviewed Sep 10, 2023

View reviewed changes

jonyeokj and others added 8 commits September 13, 2023 17:28

Implement assertions for null values

7a49ebf

- Added assertions to handle null values for input in the MainWindow class. - Ensured null responses are appropriately handled in the Martin class. - Introduced error handling for scenarios where the input is empty.

Merge pull request #1 from jonyeokj/branch-A-Assertions

cd8ec93

Implement assertions for null values

Implement A-CodeQuality

2445700

Refactored code in the DateCommand class to minimize arrowhead style code. Also added javadoc headers for all the command messages briefly explaining what theydo, and cleaned up the headers for their respective execute() commands.

Merge pull request #2 from jonyeokj/branch-A-CodeQuality

fe7abd0

Implement A-CodeQuality

Add Java CI workflow using GitHub Actions

bc25324

Changed runtest files

13ab009

Change JDK version

8a2a77c

Add LocalDateTime support to Events

6ae82a3

jonyeokj and others added 12 commits September 17, 2023 18:51

Merge pull request #4 from jonyeokj/branch-B-Snooze

432a0c6

Implement Snooze and enhance Event format

Implement Sort Command and support for parsing Events

493ce02

Implement SortCommand to enable task sorting functionality. Extend the fromFileFormat method in Task to handle Event tasks.

Merge pull request #5 from jonyeokj/branch-C-Sort

eae61d7

Implement Sort Command and support for parsing Events

Improve GUI and updated README

d965a0e

Edit README file

e037039

Replace gradle.yml file

0cd6b98

Change PATH in runtest files

dcba0e8

Replace gradle.yml file

92022a4

Update FindCommand and Add NoTaskFoundException classes

b0556c3

Remove text-ui-test file

d9381e8

Change build.gradle file

0c52d8d

Conversation

jonyeokj commented Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Martin Bot

🎉 It's Absolutely Free! 🎉

Uh oh!

Gavino3o left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wui-hong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erohsikivar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonyeokj commented Sep 2, 2023 •

edited

Loading