[euchangxian] iP by euchangxian · Pull Request #520 · nus-cs2103-AY2324S1/ip

euchangxian · 2023-09-02T13:27:20Z

🚀 Changoose 🚀

Best task manager ever - Mom
Using Changoose changed my life for the better - Girlfriend ~~(real)~~

🎉 This is the latest release of Changoose v0.1! 🎉

Manage your TODOS!
Manage your DEADLINES!
Manage your EVENTS!

🤩 What's New? 🤩

All-new name! No more old boring Duke! Say hi to Changoose!
Cutting-edge Task Manager technology!
State-of-the-art intelligence! Changoose can understand ~~(almost)~~ anything you tell it!

🦾 Performance Enhancements 🦾

Upgraded Changoose's intelligence.
- Now you can add tasks by typing deadline feed goose \by today and Changoose will understand you!
Fed the 🐹hamsters🐹. Now Changoose is faster than ever!
Completes your tasks for you (Coming soon)

TODO

/**
* Completes the given task.
* 
* @param task The task to complete.
*/
public static void completeTask(Task task) {
  // TODO blank because I don't know what to put here.
  return;
}

Here is the link to the code for Changoose!

Changoose

This reduces repeated code.

This is done by adding an overloaded echo() method to maintain the functionality of existing code.

For improved readablity

Update startParse() to first split by spaces to handle commands with multiple words, like mark x or unmark x, where x is the index of the command.

This is to prevent Duke class from getting too bloated.

This is to prevent bloating of Duke class

LicongHuang

Overall very well written, follows the style guide very well, lgtm, can push to production

LicongHuang · 2023-09-05T12:10:17Z

+     *
+     * @return {@code true} if the file was corrupted, otherwise {@code false}.
+     */
+    public boolean wasFileCorrupted() {


Method name should start with a verb, i.e. checkFileCorrupted()

LicongHuang · 2023-09-05T12:10:28Z

+        return Optional.of(task);
+    }
+
+    public List<Task> searchTasks(String keyword) {


Good use of monads

Second this

LicongHuang · 2023-09-05T12:12:19Z

@@ -0,0 +1,9 @@
+todo master rizz


I also wish

This is in preparation to integrate JavaFX with Duke, preventing the Duke class from becoming too bloated.

Refactor existing classes, mainly changing the return type of UiService to return a String which is displayed in the GUI window.

Add a GUI to Duke.

PearlynnT

LGTM Great job! 😄

PearlynnT · 2023-09-06T18:04:28Z

+                throw new InvalidCommandInputException("Provide a keyword for find command! :<");
+            }
+            return new FindTaskCommand(dukeBot, uiService, args.get(0));
+        case "todo":


Suggested change

case "todo":

case "todo":

// Fallthrough

The explicit // Fallthrough comment should be included whenever there is a case statement without a break statement.

PearlynnT · 2023-09-06T18:05:51Z

+            }
+            return new FindTaskCommand(dukeBot, uiService, args.get(0));
+        case "todo":
+        case "deadline":


Suggested change

case "deadline":

case "deadline":

// Fallthrough

The explicit // Fallthrough comment should be included whenever there is a case statement without a break statement.

PearlynnT · 2023-09-06T18:13:07Z

+        return Optional.of(task);
+    }
+
+    public List<Task> searchTasks(String keyword) {


Second this

PearlynnT · 2023-09-06T18:27:27Z

+
+        try (FileInputStream fis = new FileInputStream(file);
+             ObjectInputStream ois = new ObjectInputStream(fis)) {
+            @SuppressWarnings("unchecked")


Appropriate use

TaskFactory is responsible for the creation of new Tasks, and in no cases does it return a null task. Since there should only be one way of adding a task to TaskList, by calling TaskList::add, there should be no null tasks added to the TaskList. Neither should there by any null task retrieved by any exposed methods.

This is to better reflect immutability.

Add assert statements to TaskList

Branch-A-Streams

Add java_ci.yml file to ensure code quality

Improve Code Quality

Duke can now parse dates like "monday", "tuesday",..., etc and understands it as the next Monday, Tuesday etc.

Add more special date inputs

If the start date supplied is after the end date, an exception is thrown.

damithc and others added 30 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

Rename chatbot to Changoose and add dividers

4b0f973

Add Duke::startParse and Duke::echo

4d0555f

Replace usage of System.out.println with echo()

6cb6190

This reduces repeated code.

Add indentLeft() and indent echo's output

dc4d576

Add botName and scanner as Duke instance variables

8fc0b5c

Add getter for Duke botName

19b3d6d

Change startParse() and echo() to instance methods

8a29887

Add taskList field

8101159

Update startParse() to add input into taskList

6acaa3f

Update echo() output text

a7c17e3

Update echo() to take in a prefix

d85ffb3

This is done by adding an overloaded echo() method to maintain the functionality of existing code.

Add printTasks() method

7647a56

Add line breaks in between methods

5122a40

For improved readablity

Update echo() to handle a list of strings

4e7bd85

Fix printing of dividers between every task

da290a2

Add switch case to handle list command

87fd0f1

Add Task class

2071d57

Update fields and methods to use Task class

d60dcc2

Remove useless scanner field

82ce6a1

Add markTask() and unmarkTask()

a882d89

Add cases for mark and unmark

c78a6b4

Update startParse() to first split by spaces to handle commands with multiple words, like mark x or unmark x, where x is the index of the command.

Add getters for taskName and isDone in Task

6804017

Extract print methods to OutputService

28ee5f5

This is to prevent Duke class from getting too bloated.

Remove Duke field in OutputService

814e1e1

Change entry point of program to CliParserService

4623a32

This is to prevent bloating of Duke class

Add custom Exceptions

cc457e3

Add TaskType enum

612ae9a

Add variants of Tasks

7a2e15b

LicongHuang reviewed Sep 5, 2023

View reviewed changes

euchangxian added 5 commits September 5, 2023 21:24

Merge branch 'branch-A-CheckStyle'

3c89a10

Extract main method from Duke to Main class

55ea565

This is in preparation to integrate JavaFX with Duke, preventing the Duke class from becoming too bloated.

Refactor Duke class

877ec10

Add JavaFX GUI

f0ad6c2

Refactor existing classes, mainly changing the return type of UiService to return a String which is displayed in the GUI window.

Merge branch 'branch-Level-10'

2ab6853

Add a GUI to Duke.

PearlynnT reviewed Sep 6, 2023

View reviewed changes

euchangxian added 23 commits September 15, 2023 15:54

Add final modifier to ParseResult fields

dbfbd5c

This is to better reflect immutability.

Fix UnmarkTaskCommand calling wrong UiService method

44f797d

Change formatTaskList to use Streams

4178a85

Add unit test for formatTaskList

86a595e

Remove unused import

e2f88dd

Reorganize imports in OutputServiceTest

e135e8e

Add java_ci.yml file to ensure code quality

0d25470

Merge pull request #3 from euchangxian/branch-A-Assertions

a9d312f

Add assert statements to TaskList

Merge pull request #2 from euchangxian/branch-A-Streams

418fb96

Branch-A-Streams

Merge pull request #1 from euchangxian/branch-A-CI

ac9b0fd

Add java_ci.yml file to ensure code quality

Fix checkstyle violations

8382d84

Merge pull request #5 from euchangxian/branch-A-CodeQuality

64a92fb

Improve Code Quality

Add more strings that can be understood as dates

60f35f8

Duke can now parse dates like "monday", "tuesday",..., etc and understands it as the next Monday, Tuesday etc.

Add test for days of week string input

ef21747

Merge pull request #6 from euchangxian/branch-C-NaturalDates

4086743

Add more special date inputs

Update Event Task date arguments logic

e41a0f7

If the start date supplied is after the end date, an exception is thrown.

Merge branch 'branch-A-MoreErrorHandling'

34135b7

Add Ui.png

36e88d0

Update README.md

7322b31

Merge branch 'branch-A-UserGuide'

430035b

Add JavaFX dependencies in build.gradle

5d6f200

Update javaFX dependencies

9e8d6ad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[euchangxian] iP#520

[euchangxian] iP#520
euchangxian wants to merge 120 commits into
nus-cs2103-AY2324S1:masterfrom
euchangxian:master

euchangxian commented Sep 2, 2023 •

edited

Loading

Uh oh!

LicongHuang left a comment

Uh oh!

LicongHuang Sep 5, 2023

Uh oh!

LicongHuang Sep 5, 2023

Uh oh!

PearlynnT Sep 6, 2023

Uh oh!

LicongHuang Sep 5, 2023

Uh oh!

PearlynnT left a comment

Uh oh!

PearlynnT Sep 6, 2023

Uh oh!

PearlynnT Sep 6, 2023

Uh oh!

PearlynnT Sep 6, 2023

Uh oh!

PearlynnT Sep 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

euchangxian commented Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changoose 🚀

🎉 This is the latest release of Changoose v0.1! 🎉

🤩 What's New? 🤩

🦾 Performance Enhancements 🦾

TODO

Here is the link to the code for Changoose!

Uh oh!

LicongHuang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PearlynnT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

euchangxian commented Sep 2, 2023 •

edited

Loading