[jellywaiyan] iP by jellywaiyan · Pull Request #538 · nus-cs2103-AY2324S1/ip

jellywaiyan · 2023-09-03T15:11:35Z

Jelly

Hello :o

Jelly frees your mind of having to remember things you need to do. It's,

Text-based
Easy to learn
~~FAST~~ MAYBE FAST to use :o

All you need to do is,

Download it from here.
Double-click it.
Add your tasks.
Let it manage your tasks for you 😮

And it is FREE!

Features:

Managing tasks
Managing deadlines
Reminders

If you are a java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…port

# Conflicts: # src/main/java/Jelly/main/Storage.java # src/main/java/Jelly/main/TaskList.java # src/main/java/Jelly/main/Ui.java # src/main/java/Jelly/task/Deadline.java # src/main/java/Jelly/task/Event.java # src/main/java/Jelly/task/Todo.java

# Conflicts: # src/main/java/Jelly/main/Jelly.java # src/main/java/Jelly/main/Ui.java

yiwen101

Looks good
Quite comprehensive documentation
Well designed

yiwen101 · 2023-09-07T03:22:16Z

    }
+
    @Override
    public String writeToFile() {


Could be better named.
I do not expect"writeToFile" to be a method that returns the String to be written

yiwen101 · 2023-09-07T03:25:25Z

+    /**
+     * The main initialiser for the Jelly Chat bot.
+     *
+     * @param args


I do not think "@param args" help much
And I believe that you do not need to document every method as well.

yiwen101 · 2023-09-07T03:27:30Z

+    /**
+     * Prints out a welcome message when the Chat Bot is booted up.
+     */
    public void startUpMessage() {


sounds like a noun

yiwen101 · 2023-09-07T03:28:19Z

+     * @param addedTask The task that was added.
+     * @param noOfTasks The total number of tasks in the list after adding.
+     */
+    public void addedTaskMessage(Task addedTask, int noOfTasks) {


yiwen101 · 2023-09-07T03:28:31Z

+    /**
+     * Displays a final message to the user before the Chat Bot shuts down.
+     */
    public void byeMessage() {


yiwen101 · 2023-09-07T03:29:43Z

+     * Should not happen, as tasks should be either one of these: todo, deadline or event.
+     * @return Error message.
+     */
    public String writeToFile() {


if this should not happen, why not throw exception when called?

ElginTZM

Looks great! No major coding standard issues, just some minor issues with how you name some variables like the other reviewer have mentioned

ElginTZM · 2023-09-08T06:41:46Z

+    private String description;
+
+    private String fromWhen;
+
+    private String toWhen;


Perhaps can be grouped together

ElginTZM · 2023-09-08T07:08:26Z

+import Jelly.task.Task;
+import Jelly.task.Todo;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertFalse;


Perhaps you can separate out the imports?

ElginTZM · 2023-09-08T07:11:34Z

+
+public class StorageTest {
+    @Test
+    public void startUpTest() throws IOException, JellyException {


Test methods name can utilize another convention for naming them: featureUnderTest_testScenario_expectedBehavior()

Delete command: Save to file after deleting Mark command: Save to file after marking a task as done Unmark command: Save to file after marking a task as not done Previously, these commands did not save to file, which caused the file to be outdated. Let's, *add a saveToFile method after completing the command

Improve code quality by making methods more efficient and readable.

Assert feature allows the documentation of important assumptions that should hold at various points in the code. Let's, *add assertions in Task, Parser,DeleteCommand, MarkCommand, UnmarkCommand.

Current implementation does not use assertions.

damithc and others added 30 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

Level-0

5f41e1b

Leve-1

7845ef4

Level-2

0a8f1fa

Level-3

d757c5a

Level-4

855fdbe

A-TextUiTesting

8ad03a0

Level-5

9e78b42

Level-6

4a262ae

Level-6

f98495d

Level-7

a1abb5f

Level-7v2

8708c8a

Merge branch 'branch-Level-7'

4dbc78f

Level-8 deadline done, event left to do

a6a9d84

Level-8

7196ad9

Merge branch 'branch-Level-8'

8418609

Add Storage, TaskList, Ui

ffc0ca4

A-MoreOOP

9196ca0

Merge remote-tracking branch 'jellywaiyan/A-MoreOOP'

f4cfe37

A-Packages

40dccfa

Merge remote-tracking branch 'jellywaiyan/A-Packages'

ec17221

Merge remote-tracking branch 'jellywaiyan/master' into add-gradle-sup…

1036713

…port

A-Gradle

eb3af70

A-JUnit

e349452

Merge remote-tracking branch 'jellywaiyan/A-JUnit'

298034b

A-Jar

7153636

Merge tag 'A-Jar'

f296862

Added javadocs to most methods/classes

f424f95

A-CodingStandard

092aca3

jellywaiyan added 4 commits September 6, 2023 13:21

Level-9

ef85ff8

Merge remote-tracking branch 'jellywaiyan/A-JavaDoc'

accd66b

Merge remote-tracking branch 'jellywaiyan/Level-9'

c4e9d23

# Conflicts: # src/main/java/Jelly/main/Jelly.java # src/main/java/Jelly/main/Ui.java

yiwen101 reviewed Sep 7, 2023

View reviewed changes

ElginTZM reviewed Sep 8, 2023

View reviewed changes

jellywaiyan and others added 18 commits September 10, 2023 01:03

A-CheckStyle

69dfcb2

A-CheckStyle

78be3ef

Merge remote-tracking branch 'jellywaiyan/A-CheckStyle'

5797609

Level-10

cb808e7

Merge remote-tracking branch 'jellywaiyan/branch-Level-10'

4e8dd06

Merge pull request #2 from jellywaiyan/branch-A-CodeQuality

43f2b52

Improve code quality by making methods more efficient and readable.

Current implementation does not use assertions.

22a0934

Assert feature allows the documentation of important assumptions that should hold at various points in the code. Let's, *add assertions in Task, Parser,DeleteCommand, MarkCommand, UnmarkCommand.

Small change

7c36a44

Merge branch 'master' into A-Assertions

aef83c9

Merge A-Assertions

288f645

Merge pull request #3 from jellywaiyan/A-Assertions

fc579d9

Current implementation does not use assertions.

Fix checkstyle

ccfa675

Add priority to tasks

86abced

Add priority

5a0e075

Merge remote-tracking branch 'jellywaiyan/C-Priority'

74fff83

Change README, add Ui.png

1af5407

Configure jar file

4015151

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[jellywaiyan] iP#538

[jellywaiyan] iP#538
jellywaiyan wants to merge 52 commits into
nus-cs2103-AY2324S1:masterfrom
jellywaiyan:master

jellywaiyan commented Sep 3, 2023 •

edited

Loading

Uh oh!

yiwen101 left a comment

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

yiwen101 Sep 7, 2023

Uh oh!

ElginTZM left a comment •

edited

Loading

Uh oh!

ElginTZM Sep 8, 2023 •

edited

Loading

Uh oh!

ElginTZM Sep 8, 2023

Uh oh!

ElginTZM Sep 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jellywaiyan commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jelly

Jelly frees your mind of having to remember things you need to do. It's,

All you need to do is,

Features:

Uh oh!

yiwen101 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ElginTZM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ElginTZM Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jellywaiyan commented Sep 3, 2023 •

edited

Loading

ElginTZM left a comment •

edited

Loading

ElginTZM Sep 8, 2023 •

edited

Loading