[felibunnyy] iP by felibunnyy · Pull Request #540 · nus-cs2103-AY2324S1/ip

felibunnyy · 2023-09-03T19:29:20Z

No description provided.

ZD292 · 2023-09-05T15:21:06Z

Looks good to me! 😄

Heran9 · 2023-09-06T12:40:19Z

 public class Duke {
    public static void main(String[] args) {
-        String logo = " ____        _        \n"
-                + "|  _ \\ _   _| | _____ \n"
-                + "| | | | | | | |/ / _ \\\n"
-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        Scanner scanner = new Scanner(System.in);
+        boolean isRunning = true;
+        int taskCount = 0;
+        ArrayList<Task> tasks = new ArrayList<>();
+//        Task[] tasks =  new Task[100];
+        System.out.println("Hello! I'm Chatty\nWhat can I do for you?");
+        System.out.println("____________________________________________________________");
+        while (isRunning) {
+            try {
+                String userInput = scanner.nextLine();
+                System.out.println("____________________________________________________________");
+                if (userInput.equals("bye")) {
+                    System.out.println("Bye. Hope to see you again soon!");
+                    isRunning = false;
+                } else if (userInput.equals("list")){
+                    System.out.println("Here are the tasks in your list:");
+                    for (int i = 0; i < taskCount; i++) {
+                        System.out.println(i + 1 + "." + tasks.get(i));
+                    }
+                } else if (userInput.startsWith("mark ")) {
+                    System.out.println("Nice! I've marked this task as done:");
+                    int taskIndex = Integer.parseInt(userInput.substring(5)) - 1;
+                    tasks.get(taskIndex).switchCheck();
+                    System.out.println(tasks.get(taskIndex).toString());
+                } else if (userInput.startsWith("unmark ")) {
+                    System.out.println("OK, I've marked this task as not done yet:");
+                    int taskIndex = Integer.parseInt(userInput.substring(7)) - 1;
+                    tasks.get(taskIndex).switchCheck();
+                    System.out.println(tasks.get(taskIndex).toString());
+                } else if (userInput.startsWith("todo ")) {
+                    if (userInput.length() <= 5) {
+                        throw new DukeException("OOPS!!! The description of a todo cannot be empty.");
+                    }
+                    Task newToDo = new Todo(userInput.substring(5));
+                    System.out.println("Got it. I've added this task:");
+                    tasks.add(new Todo(userInput));
+                    taskCount++;
+                    System.out.println(newToDo.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("deadline ")) {
+                    System.out.println("Got it. I've added this task:");
+                    String description = userInput.substring(9, userInput.indexOf("/by")).trim();
+                    String by = userInput.substring(userInput.indexOf("/by") + 4).trim();
+                    Task newDeadline = new Deadline(description, by);
+                    tasks.add(newDeadline);
+                    taskCount++;
+                    System.out.println(newDeadline.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("event ")) {
+                    System.out.println("Got it. I've added this task:");
+                    String description = userInput.substring(6, userInput.indexOf("/from")).trim();
+                    String from = userInput.substring(userInput.indexOf("/from") + 6, userInput.indexOf("/to")).trim();
+                    String to = userInput.substring(userInput.indexOf("/to") + 4).trim();
+                    Task newEvent = new Event(description, from, to);
+                    tasks.add(newEvent);
+                    taskCount++;
+                    System.out.println(newEvent.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("delete ")) {
+                    System.out.println("Noted. I've removed this task:");
+                    int taskIndex = Integer.parseInt(userInput.substring(7)) - 1;
+                    System.out.println(tasks.get(taskIndex));
+                    tasks.remove(taskIndex);
+                    taskCount--;
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else {
+                    throw new DukeException("OOPS!!! I'm sorry, but I don't know what that means :-(");
+                }
+            } catch (DukeException e) {
+                // Handle Duke-specific exceptions with meaningful error messages
+                System.out.println(e.getMessage());
+            }
+            System.out.println("____________________________________________________________");
+        }
+        scanner.close();
    }


Can add more Javadosc to the code

Heran9 · 2023-09-06T13:42:13Z

+        while (isRunning) {
+            try {
+                String userInput = scanner.nextLine();
+                System.out.println("____________________________________________________________");
+                if (userInput.equals("bye")) {
+                    System.out.println("Bye. Hope to see you again soon!");
+                    isRunning = false;
+                } else if (userInput.equals("list")){
+                    System.out.println("Here are the tasks in your list:");
+                    for (int i = 0; i < taskCount; i++) {
+                        System.out.println(i + 1 + "." + tasks.get(i));
+                    }
+                } else if (userInput.startsWith("mark ")) {
+                    System.out.println("Nice! I've marked this task as done:");
+                    int taskIndex = Integer.parseInt(userInput.substring(5)) - 1;
+                    tasks.get(taskIndex).switchCheck();
+                    System.out.println(tasks.get(taskIndex).toString());
+                } else if (userInput.startsWith("unmark ")) {
+                    System.out.println("OK, I've marked this task as not done yet:");
+                    int taskIndex = Integer.parseInt(userInput.substring(7)) - 1;
+                    tasks.get(taskIndex).switchCheck();
+                    System.out.println(tasks.get(taskIndex).toString());
+                } else if (userInput.startsWith("todo ")) {
+                    if (userInput.length() <= 5) {
+                        throw new DukeException("OOPS!!! The description of a todo cannot be empty.");
+                    }
+                    Task newToDo = new Todo(userInput.substring(5));
+                    System.out.println("Got it. I've added this task:");
+                    tasks.add(new Todo(userInput));
+                    taskCount++;
+                    System.out.println(newToDo.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("deadline ")) {
+                    System.out.println("Got it. I've added this task:");
+                    String description = userInput.substring(9, userInput.indexOf("/by")).trim();
+                    String by = userInput.substring(userInput.indexOf("/by") + 4).trim();
+                    Task newDeadline = new Deadline(description, by);
+                    tasks.add(newDeadline);
+                    taskCount++;
+                    System.out.println(newDeadline.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("event ")) {
+                    System.out.println("Got it. I've added this task:");
+                    String description = userInput.substring(6, userInput.indexOf("/from")).trim();
+                    String from = userInput.substring(userInput.indexOf("/from") + 6, userInput.indexOf("/to")).trim();
+                    String to = userInput.substring(userInput.indexOf("/to") + 4).trim();
+                    Task newEvent = new Event(description, from, to);
+                    tasks.add(newEvent);
+                    taskCount++;
+                    System.out.println(newEvent.toString());
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else if (userInput.startsWith("delete ")) {
+                    System.out.println("Noted. I've removed this task:");
+                    int taskIndex = Integer.parseInt(userInput.substring(7)) - 1;
+                    System.out.println(tasks.get(taskIndex));
+                    tasks.remove(taskIndex);
+                    taskCount--;
+                    System.out.println("Now you have " + taskCount + " tasks in the list.");
+                } else {
+                    throw new DukeException("OOPS!!! I'm sorry, but I don't know what that means :-(");
+                }


Can put all these into another class, which makes it more simple and clear

lawruixi

I noticed some minor mistakes with adhering to the code standards, but overall, looks good to me!

lawruixi · 2023-09-07T00:41:53Z

+                if (userInput.equals("bye")) {
+                    System.out.println("Bye. Hope to see you again soon!");
+                    isRunning = false;
+                } else if (userInput.equals("list")){


Suggested change

} else if (userInput.equals("list")){

} else if (userInput.equals("list")) {

lawruixi · 2023-09-09T01:50:14Z

+                    String description = userInput.substring(9, userInput.indexOf("/by")).trim();
+                    String by = userInput.substring(userInput.indexOf("/by") + 4).trim();


Would there be issues if no /by parameter is specified? Perhaps a DukeException could be thrown in that case?

lawruixi · 2023-09-09T01:53:31Z

+                } else if (userInput.startsWith("event ")) {
+                    System.out.println("Got it. I've added this task:");
+                    String description = userInput.substring(6, userInput.indexOf("/from")).trim();
+                    String from = userInput.substring(userInput.indexOf("/from") + 6, userInput.indexOf("/to")).trim();


Suggested change

String from = userInput.substring(userInput.indexOf("/from") + 6, userInput.indexOf("/to")).trim();

String from = userInput.substring(

userInput.indexOf("/from") + 6, userInput.indexOf("/to")

).trim();

the original line is over 100 characters ;-;

lawruixi · 2023-09-09T01:57:08Z

+//        Task[] tasks =  new Task[100];
+        System.out.println("Hello! I'm Chatty\nWhat can I do for you?");
+        System.out.println("____________________________________________________________");
+        while (isRunning) {


I like that there are spaces around the brackets :D

package all classes into chatty package

…ded.

damithc and others added 9 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

change initial output of chatbot

6561147

modify gitignore to ignore .class files

a59cb5c

Level 2: Add, List

a02cf9f

add task class and level 3 of duke class

c5cea7a

modify logic for Duke, add class Todo Deadline Event that extends Task

3d35347

add DukeException class to handle errors in Duke class

62a9e52

level 6 initial commit

a63d20f

Heran9 reviewed Sep 6, 2023

View reviewed changes

lawruixi reviewed Sep 9, 2023

View reviewed changes

felibunnyy added 11 commits September 10, 2023 14:45

Automate I/O tests

4a80c47

Level 7. Save

ba7c244

Merge branch 'branch-Level-7'

8472674

Level 8. Dates and Times

df6fe03

Merge branch 'branch-Level-8'

79cd76e

A-MoreOOP: Use More OOP

2bc1353

Merge remote-tracking branch 'origin/A-MoreOOP'

671d520

add package chatty

ab1f79e

Merge tag 'A-Packages'

4ccc0d4

package all classes into chatty package

modify file path in runtest.sh

1dcfad7

Merge branch 'add-gradle-support' which has been already kindly provi…

977dd21

…ded.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[felibunnyy] iP#540

[felibunnyy] iP#540
felibunnyy wants to merge 20 commits into
nus-cs2103-AY2324S1:masterfrom
felibunnyy:master

felibunnyy commented Sep 3, 2023

Uh oh!

ZD292 commented Sep 5, 2023

Uh oh!

Heran9 Sep 6, 2023

Uh oh!

Heran9 Sep 6, 2023

Uh oh!

lawruixi left a comment

Uh oh!

lawruixi Sep 7, 2023

Uh oh!

lawruixi Sep 9, 2023

Uh oh!

lawruixi Sep 9, 2023

Uh oh!

lawruixi Sep 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	} else if (userInput.equals("list")){
	} else if (userInput.equals("list")) {

		String description = userInput.substring(9, userInput.indexOf("/by")).trim();
		String by = userInput.substring(userInput.indexOf("/by") + 4).trim();

Conversation

felibunnyy commented Sep 3, 2023

Uh oh!

ZD292 commented Sep 5, 2023

Uh oh!

Heran9 Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

Heran9 Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

lawruixi left a comment

Choose a reason for hiding this comment

Uh oh!

lawruixi Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

lawruixi Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

lawruixi Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

lawruixi Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants