[Luah Jun Yang} iP by LuahJunYang · Pull Request #571 · nus-cs2103-AY2324S1/ip

LuahJunYang · 2023-09-07T14:23:05Z

Frenchie

"I need more boulets." -Frenchie

Frenchie keeps track of all tasks in your life in a fuss-free CLI. It is:

Simple to learn
Text-commands based
SUPER FAST

All you need to start using Frenchie is:

Download Frenchie from here
Double click the jar file
Enter your tasks in the right format
Let it track all of your tasks for you 👍🏻

Features:

Task Tracking
Reminders for Tasks with deadlines (coming soon!)

For those of you who code, Frenchie is written in java and you can experiment with it to add your own features!

Here is the main() method of Frenchie:

public static void main(String[] args) {
        new Frenchie("frenchie.txt").run();
    }

…ut text when 'list' is input

…ete method to Frenchie.java, level 3 completed

… for todo, event, deadline. Level 4 Complete.

…w. Level 5 completed up till basic exceptions.

…st instead of List

sushiyade · 2023-09-08T05:08:52Z

+                } else if (input.contains("delete")){
+                    String[] parts = input.split(" ");
+                    int index = Integer.parseInt(parts[1]) - 1;
+                    Task target_task = frenchie.tasks.get(index);
+                    frenchie.deleteTask(index);
+                    System.out.println("____________________________________________________________\n" +
+                            "Noted. I've removed this task: \n" +
+                            target_task.toString()   + "\n" +
+                            "Now you have " + frenchie.getNumOfTasks() + " tasks in the list.\n" +
+                            "____________________________________________________________");


As the number of keywords increase, perhaps you might want to start looking at enums to have a collection of your keywords!

Seconded. In addition, perhaps you may wish to divide all the logic in your main method into several other methods, as the complexity of your program increases.

yytan25

Good use of OOP and inheritance for the subclasses of Task. You can still improve on your coding style and your use of SLAP.

yytan25 · 2023-09-08T06:47:29Z

+        this.tasks = new ArrayList<>();
+    }
+
+    public void addTask(Task NEW_TASK) {


The Task parameter is a variable, not a constant. So it should be in camelCase instead, i.e. newTask.

yytan25 · 2023-09-08T06:48:17Z

+    }
+
+    public void completeTask(int index) {
+        tasks.get(index).mark_as_completed();


Please follow the camelCase convention for methods, i.e. markAsCompleted.

yytan25 · 2023-09-08T06:51:12Z

+                } else if (input.contains("delete")){
+                    String[] parts = input.split(" ");
+                    int index = Integer.parseInt(parts[1]) - 1;
+                    Task target_task = frenchie.tasks.get(index);
+                    frenchie.deleteTask(index);
+                    System.out.println("____________________________________________________________\n" +
+                            "Noted. I've removed this task: \n" +
+                            target_task.toString()   + "\n" +
+                            "Now you have " + frenchie.getNumOfTasks() + " tasks in the list.\n" +
+                            "____________________________________________________________");


Seconded. In addition, perhaps you may wish to divide all the logic in your main method into several other methods, as the complexity of your program increases.

yytan25 · 2023-09-08T06:52:10Z

+                + "|____/ \\__,_|_|\\_\\___|\n";
+        System.out.println("Hello from\n" + logo); */
+        Frenchie frenchie = new Frenchie();
+        String skeleton = "____________________________________________________________\n" +


When breaking up a statement into multiple lines, the + operator should be on a new line.

yytan25 · 2023-09-08T06:53:14Z

@@ -0,0 +1,11 @@
+class ToDo extends Task {


Perhaps you should add the public access modifier to your class definition?

yytan25 · 2023-09-08T06:54:17Z

@@ -0,0 +1,16 @@
+public class Event extends Task{


Should leave a whitespace between your definition and the curly braces, as in
public class Event extends Task {

yytan25 · 2023-09-08T06:57:31Z

+                    break;
+                } else if (input.equals("list")) { //Checking if user is looking to list all tasks
+                    frenchie.listTasks();
+                } else if (input.contains("mark")) { //Checking if user input is to mark/unmark tasks


This doesn't check if the input is either mark or unmark. If a user inputs markzzzzzz, this will still be treated as unmark even though it is an invalid command, because the input still contains the substring mark. To avoid similar problems like this, perhaps you should use Java Enums to ensure input validity.

…tors for Event and Deadline classes as well as save and load methods for Frenchie

…skList class

…he scanner is closed

Kevin-Liusx · 2023-09-20T03:19:42Z

+                    LocalDateTime storedEndTime = LocalDateTime.parse(endTime, inputFormatter);
+                    DateTimeFormatter desiredFormatter = DateTimeFormatter.ofPattern("dd/MM/yyyy HH:mm");
+                    String constructorStartTime = storedStartTime.format(desiredFormatter);
+                    String constructorEndTime = storedEndTime.format(desiredFormatter);


I think this part of your code and be improved? Maybe try to use some other methods?😊

…asses.

…rnMatchTasks() method to TaskList.java. Level-9 Completed.

…uccessfully.

Removed unused methods and corrected the order of import statements to be in the correct lexographical order. Fixed the error of tasks not loading from frenchie.txt by calling storage.load() before parsing the input String.

Improving on Code Quality

Added help as an enum in Command and included 'help' as a case for the Parser class. Added a quick start guide that will be presented to the user when user inputs 'help' as the command.

Add help function

damithc and others added 12 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

Level 0

8f211eb

Finished Level 1, renamed bot to Frenchie

c442a23

Added functionality to store user input as list and print out all inp…

e26ad60

…ut text when 'list' is input

Created Task class to be used for Frenchie

2826c8b

Added addTask and listTask methods and a constructor to Frenchie.java

c163e3f

Added mark as incomplete method to Task.java and complete and uncompl…

6880516

…ete method to Frenchie.java, level 3 completed

Created new Task subclasses

9502380

Added if-else statements and updated toString() methods for checking…

6403c3d

… for todo, event, deadline. Level 4 Complete.

Created new FrenchieException class to handle basic exceptions for no…

f8faf33

…w. Level 5 completed up till basic exceptions.

Added delete function to frenchie, changed tasks attribute to ArrayLi…

59151ce

…st instead of List

sushiyade reviewed Sep 8, 2023

View reviewed changes

yytan25 reviewed Sep 8, 2023

View reviewed changes

LuahJunYang added 6 commits September 9, 2023 23:07

Added functions saveTasksToFile and readTasksFromFile

76c74cf

Added LocalDateTime and DateTimeFormatter functionalities to construc…

efa2cac

…tors for Event and Deadline classes as well as save and load methods for Frenchie

Implemented enum for Commands, abstracted UI, Parser, Storage, and Ta…

cf2306e

…skList class

Bug fixing for bye command, causing an illegal state exception when t…

3a10e8d

…he scanner is closed

Packaged all classes into package.frenchie

c59c708

Merge branch 'add-gradle-support' for 'A-Gradle'

1435a48

Kevin-Liusx reviewed Sep 20, 2023

View reviewed changes

LuahJunYang and others added 9 commits September 21, 2023 10:50

Updated build.gradle file, wrote J-unit tests ToDoTest and TaskTest

fb9f638

Added JavaDoc comments for Task, ToDo, Deadline, Event, Ui, Parser cl…

2ac3943

…asses.

Added findMessage() method to Ui.java, find enum to Command, and retu…

e8b0d86

…rnMatchTasks() method to TaskList.java. Level-9 Completed.

Resolved merge conflict in Ui.java

eae69dd

Edited void functions to return String for the GUI. Implemented GUI s…

04310fd

…uccessfully.

Improving on Code Quality

68fc1cb

Removed unused methods and corrected the order of import statements to be in the correct lexographical order. Fixed the error of tasks not loading from frenchie.txt by calling storage.load() before parsing the input String.

Merge pull request #3 from LuahJunYang/branch-A-CodeQuality

4364715

Improving on Code Quality

Add help function

c59a6cf

Added help as an enum in Command and included 'help' as a case for the Parser class. Added a quick start guide that will be presented to the user when user inputs 'help' as the command.

Merge pull request #4 from LuahJunYang/branch-C-Help

43a2dd1

Add help function

LuahJunYang added 4 commits September 23, 2023 14:58

Added User Guide in README.md

4806d6d

Updating README for github page

8633cba

Added Screenshot of UI

3f79e97

Updated mainClass in build.gradle to fix the jar file not running

7b1615e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Luah Jun Yang} iP#571

[Luah Jun Yang} iP#571
LuahJunYang wants to merge 31 commits into
nus-cs2103-AY2324S1:masterfrom
LuahJunYang:master

LuahJunYang commented Sep 7, 2023 •

edited

Loading

Uh oh!

sushiyade Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 left a comment

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

yytan25 Sep 8, 2023

Uh oh!

Kevin-Liusx Sep 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LuahJunYang commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Frenchie

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yytan25 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LuahJunYang commented Sep 7, 2023 •

edited

Loading